pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <tmunro@postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Test replay of regression tests, attempt II.
Date: Mon, 17 Jan 2022 12:24:48 -0500
Message-ID: <8373.1642440288@sss.pgh.pa.us> (raw)
In-Reply-To: <4114834.1642433121@sss.pgh.pa.us>
References: <E1n9Io8-0007At-FQ@gemulon.postgresql.org>
	<YeUUiruW+mqNNGIG@paquier.xyz>
	<4114834.1642433121@sss.pgh.pa.us>

I wrote:
> I'm quite appalled that this patch has apparently added an entire new run
> of the core regression tests to the standard check-world/buildfarm cycle.

Not only that, but it leaves junk that is neither cleaned by "make clean"
nor .gitignored:

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        primary.dump
        results/
        standby.dump

$ make clean
rm -rf tmp_check

These files should have been put into the tmp_check directory...
that's what it's for.

			regards, tom lane





view thread (18+ messages)  latest in thread

Message-ID: <8373.1642440288@sss.pgh.pa.us>
Permalink:  ../8373.1642440288@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/8373.1642440288@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, tmunro@postgresql.org, michael@paquier.xyz
  Subject: Re: pgsql: Test replay of regression tests, attempt II.
  In-Reply-To: <8373.1642440288@sss.pgh.pa.us>
  References: <E1n9Io8-0007At-FQ@gemulon.postgresql.org> <YeUUiruW+mqNNGIG@paquier.xyz> <4114834.1642433121@sss.pgh.pa.us> <8373.1642440288@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox