pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: issue with meson builds on msys2
Date: Wed, 26 Apr 2023 10:32:34 -0400
Message-ID: <848511.1682519554@sss.pgh.pa.us> (raw)
In-Reply-To: <6efeb45a-07f9-2291-c8f8-9fb4abbb6ebc@dunslane.net>
References: <E1poQg3-003Xv9-UZ@gemulon.postgresql.org>
	<08dd6053-deee-52e9-954b-eb69232905c9@dunslane.net>
	<2506819.1681761221@sss.pgh.pa.us>
	<7d7dcc20-ba19-5340-9be8-f255e8b42edc@dunslane.net>
	<20230420150652.jciazjap223iznjp@awork3.anarazel.de>
	<5bddd941-9819-6655-7a71-3f346050583e@dunslane.net>
	<6efeb45a-07f9-2291-c8f8-9fb4abbb6ebc@dunslane.net>

Andrew Dunstan <andrew@dunslane.net> writes:
>> For some reason which makes no sense to me the buildfarm animal fails 
>> at the first Stop-Db step. The DB is actually stopped, but pg_ctl 
>> returns a non-zero status. The thing that's really odd is that meson 
>> isn't at all involved in this step. But it's happened enough that I've 
>> had to back off using meson builds on fairywren - I'm going to do more 
>> testing on a new Windows instance.

> Here's a simple illustration of the problem. If I do the identical test 
> with a non-meson build there is no problem:

> pgrunner@EC2AMAZ-GCB871B UCRT64 ~/bf
> $ /usr/bin/perl -e 'chdir "root/HEAD/instkeep.2023-04-25_11-09-41"; 
> system("bin/pg_ctl -D data-C -l logfile stop") ; print "fail\n" if $?; '
> waiting for server to shut down....fail

Looking at the pg_ctl source code, the only way I can explain that
printout is that do_stop called wait_for_postmaster_stop which,
after one or more loops, exited via one of its exit() calls.
The lack of any message can be explained if we imagine that
write_stderr() output is going to the bit bucket.  I'd start by
changing those write_stderr's to print_msg(), which visibly
does work; that should confirm the existence of the stderr
issue and show you how wait_for_postmaster_stop is failing.

			regards, tom lane





view thread (24+ messages)  latest in thread

Message-ID: <848511.1682519554@sss.pgh.pa.us>
Permalink:  ../848511.1682519554@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/848511.1682519554@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: issue with meson builds on msys2
  In-Reply-To: <848511.1682519554@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox