From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f
Date: Thu, 20 Jan 2022 08:58:39 -0500
Message-ID: <855583.1642687119@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGKV6fOHvfiPt8=dOKzvswjAyLoFoJF1iQXMNpi7+hD1JQ@mail.gmail.com>
References: <E1nAIWI-0006et-HW@gemulon.postgresql.org>
<CA+hUKGKV6fOHvfiPt8=dOKzvswjAyLoFoJF1iQXMNpi7+hD1JQ@mail.gmail.com>
Thomas Munro <thomas.munro@gmail.com> writes:
> On Thu, Jan 20, 2022 at 10:29 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> TAP tests: check for postmaster.pid anyway when "pg_ctl start" fails.
> This seems to have caused some kind of problem for the 017_shm.pl test:
Hmm. I think the problem is that poll_start() thinks it can just call
start() a second time after a failure. If it wasn't a true failure
but a timeout, then _pid is now set and the second call complains.
I'm not entirely sure how that scenario worked before --- maybe
pg_ctl is not picky about whether the running postmaster is the
same one it started??
Anyway it seems like we need some less-fuzzy thinking in poll_start.
Haven't absorbed enough caffeine to decide what.
A possible band-aid to get rid of the buildfarm failures is to force
a higher PGCTLTIMEOUT during poll_start.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f
In-Reply-To: <855583.1642687119@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox