From: Andrew Dunstan <andrew@dunslane.net>
To: Masahiko Sawada <sawada.mshk@gmail.com>
To: Sutou Kouhei <kou@clear-code.com>
Cc: msawada@postgresql.org
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor COPY FROM to use format callback functions.
Date: Fri, 28 Feb 2025 18:06:39 -0500
Message-ID: <85aef1c9-f642-41cf-bc9a-014599f7a214@dunslane.net> (raw)
In-Reply-To: <CAD21AoCKs-AoEqhX_oFcxdTgFaE85xBT1aUaT81RSWEiFsAH8w@mail.gmail.com>
References: <CAD21AoDrDQy-cBHaghYkFb=_iPhgJg0H-hscrRtBf3r+xaVe-Q@mail.gmail.com>
<d3b11749-7d0d-40c6-b2be-0e45958881da@dunslane.net>
<CAD21AoBA414Q76LthY65NJfWbjOxXn1bdFFsD_NBhT2wPUS1SQ@mail.gmail.com>
<20250301.071641.1257013931056303227.kou@clear-code.com>
<CAD21AoCKs-AoEqhX_oFcxdTgFaE85xBT1aUaT81RSWEiFsAH8w@mail.gmail.com>
On 2025-02-28 Fr 5:39 PM, Masahiko Sawada wrote:
> On Fri, Feb 28, 2025 at 2:16 PM Sutou Kouhei<kou@clear-code.com> wrote:
>> Hi,
>>
>> Thanks for following up the patch!
>>
>> In<CAD21AoBA414Q76LthY65NJfWbjOxXn1bdFFsD_NBhT2wPUS1SQ@mail.gmail.com>
>> "Re: pgsql: Refactor COPY FROM to use format callback functions." on Fri, 28 Feb 2025 12:56:19 -0800,
>> Masahiko Sawada<sawada.mshk@gmail.com> wrote:
>>
>>> Right. I've attached the updated patch.
>> In general, this approach will work but could you keep
>> the same signature for backward compatibility?
>>
>>> --- a/src/backend/commands/copyfromparse.c
>>> +++ b/src/backend/commands/copyfromparse.c
>>> +bool
>>> +NextCopyFromRawFields(CopyFromState cstate, char ***fields, int *nfields, bool is_csv)
>>> +{
>>> + return NextCopyFromRawFieldsInternal(cstate, fields, nfields, is_csv);
>>> +}
>> NextCopyFromRawFields() uses
>> NextCopyFromRawFields(CopyFromState cstate, char ***fields,
>> int *nfields) (no "bool is_csv") before we remove it. So
>> could you use the no "bool is_csv" signature for backward
>> compatibility?
>>
>> bool
>> NextCopyFromRawFields(CopyFromState cstate, char ***fields, int *nfields)
>> {
>> return NextCopyFromRawFieldsInternal(cstate, fields, nfields, cstate->opts.csv_mode);
>> }
> I like this idea.
>
>>
>>> @@ -738,6 +742,15 @@ CopyReadBinaryData(CopyFromState cstate, char *dest, int nbytes)
>>> /*
>>> * Read raw fields in the next line for COPY FROM in text or csv mode.
>>> * Return false if no more lines.
>>> + */
>>> +bool
>>> +NextCopyFromRawFields(CopyFromState cstate, char ***fields, int *nfields, bool is_csv)
>>> +{
>>> + return NextCopyFromRawFieldsInternal(cstate, fields, nfields, is_csv);
>>> +}
>>> +
>>> +/*
>>> + * Workhorse for NextCopyFromRawFields().
>> It may be better that we don't split docs for
>> NextCopyFromRawFields() and
>> NextCopyFromRawFieldsInternal(). How about referring the
>> NextCopyFromRawFieldsInternal() doc from the
>> NextCopyFromRawFields() doc something like the following?
>>
>> /*
>> * See NextCopyFromRawFieldsInternal() for details.
>> */
>> bool
>> NextCopyFromRawFields(...)
>> {
>> ...
>> }
>>
>> /*
>> * Workhorse for NextCopyFromRawFields().
>> *
>> * Read raw fields ...
>> *
>> * ...
>> */
>> static pg_attribute_always_inline bool
>> NextCopyFromRawFieldsInternal()
>> {
>> ...
>> }
>>
> Agreed.
>
> I've updated the patch. I'm going to push it, barring any objections
> and further comments.
>
I'm OK either way - I have made changes to adapt to the API change, and
tested them.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, sawada.mshk@gmail.com, kou@clear-code.com, msawada@postgresql.org
Subject: Re: pgsql: Refactor COPY FROM to use format callback functions.
In-Reply-To: <85aef1c9-f642-41cf-bc9a-014599f7a214@dunslane.net>
References: <CAD21AoDrDQy-cBHaghYkFb=_iPhgJg0H-hscrRtBf3r+xaVe-Q@mail.gmail.com> <d3b11749-7d0d-40c6-b2be-0e45958881da@dunslane.net> <CAD21AoBA414Q76LthY65NJfWbjOxXn1bdFFsD_NBhT2wPUS1SQ@mail.gmail.com> <20250301.071641.1257013931056303227.kou@clear-code.com> <CAD21AoCKs-AoEqhX_oFcxdTgFaE85xBT1aUaT81RSWEiFsAH8w@mail.gmail.com> <85aef1c9-f642-41cf-bc9a-014599f7a214@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox