From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Try to unbreak MSVC builds for pg_waldump
Date: Sat, 8 Apr 2023 15:32:02 -0400
Message-ID: <85f136c7-4834-ffbb-e572-53c9bfdfc911@dunslane.net> (raw)
In-Reply-To: <20230408181335.c5ny27ydofu3c5ez@awork3.anarazel.de>
References: <E1plAOq-0023qQ-2e@gemulon.postgresql.org>
<CAH2-Wz=arw+7cJhwJdZmMW48=M7QNc2pKDhKJd_-f1tv0nT4Bw@mail.gmail.com>
<3598664.1680976414@sss.pgh.pa.us>
<20230408181335.c5ny27ydofu3c5ez@awork3.anarazel.de>
On 2023-04-08 Sa 14:13, Andres Freund wrote:
> Hi,
>
> On 2023-04-08 13:53:34 -0400, Tom Lane wrote:
>> Peter Geoghegan<pg@bowt.ie> writes:
>>> I was under the impression that issues like this would be caught by
>>> CI. We used to have an MSVC CI target, but that's no longer the case
>>> -- not since commit e6b6ea02. I'll need to remember that.
>> I thought we were planning to drop the MSVC build scripts for v16.
>> Is that no longer happening? If they're going to be around for
>> awhile, maybe that CI job needs to be resurrected.
> I was holding off submitting a patch until the BF supported meson - which only
> happened recently. I was actually planning to start a thread about the topic
> in the next few days.
>
> As far as I can tell, the meson build has more than feature parity with the
> "homegrown" build - the only two dependencies I haven't been able to test is
> building with are ossp-uuid (doesn't build) and kerberos (quite complicated,
> last release for windows is ages ago)
>
I am still fighting a few issues, was intending to work more on it this
week, so I'm not signing off on buildfarm support for meson quite yet. I
think we need to support the old system until meson support is fully baked.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, andres@anarazel.de, tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Try to unbreak MSVC builds for pg_waldump
In-Reply-To: <85f136c7-4834-ffbb-e572-53c9bfdfc911@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox