pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>
Cc: pgsql-committers@lists.postgresql.org, Jeff Davis <pgsql@j-davis.com>
Subject: Re: pgsql: Avoid improbable PANIC during heap_update.
Date: Sat, 01 Oct 2022 01:13:13 -0400
Message-ID: <873099.1664601193@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-Wz=gJHeAyvu-rrNN=0GcXMcE2+mm4wW=gLWDjb6d=SWYFQ@mail.gmail.com>
References: <E1lWLjP-00006Y-Ml@gemulon.postgresql.org>
	<YzVPfCKNrmi0aLEh@ahch-to>
	<YzdVJnQocQ6RHKxk@ahch-to>
	<692791.1664573331@sss.pgh.pa.us>
	<CAH2-Wz=Apna8uQAxdBUTTZX10baV-MsT9FyV6o-ifZD+knwVEQ@mail.gmail.com>
	<741997.1664574971@sss.pgh.pa.us>
	<CAH2-Wzmb3ENhfaLVv=+TwQyHSbUxvhsOPWo7Lsw7o-1kUbpzXw@mail.gmail.com>
	<841352.1664581964@sss.pgh.pa.us>
	<CAH2-WzmpfcbFxb=CNC4JiCzLLCGrWyWSV2kxaXVew9owKk4nrA@mail.gmail.com>
	<CAH2-WznFSJs7UcO1yhTWiQHjYh4PYJULc3UXz+uftLVSNcUh-Q@mail.gmail.com>
	<CAH2-WzkGUXW5+7Ry6r3iVN2vhU0cO74YrH07cXW8ykxjZUeWMA@mail.gmail.com>
	<869716.1664599080@sss.pgh.pa.us>
	<CAH2-Wz=gJHeAyvu-rrNN=0GcXMcE2+mm4wW=gLWDjb6d=SWYFQ@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> I think that the heap_delete() issue is probably in all PG versions.

Yeah, that's what I'm afraid of ...

> I am not aware of any reason why we should need the heap_update()
> fixes to be backpatched any further.

How so?  AFAICS these are exactly the same oversight, ie failure
to deal with the all-visible bit getting set partway through the
operation.  You've explained how that can happen.

			regards, tom lane





view thread (28+ messages)  latest in thread

Message-ID: <873099.1664601193@sss.pgh.pa.us>
Permalink:  ../873099.1664601193@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/873099.1664601193@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, jcasanov@systemguards.com.ec, pgsql@j-davis.com
  Subject: Re: pgsql: Avoid improbable PANIC during heap_update.
  In-Reply-To: <873099.1664601193@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox