pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Date: Fri, 14 Jun 2019 19:24:50 +0100
Message-ID: <87ef3w3u8a.fsf@news-spur.riddles.org.uk> (raw)
In-Reply-To: <26948.1560517875@sss.pgh.pa.us>
References: <E1hK8qL-0005yH-VX@gemulon.postgresql.org>
	<20190604085735.GD24018@msg.df7cb.de>
	<65800.1559662051@sss.pgh.pa.us>
	<20190605084735.GC15829@msg.df7cb.de>
	<24452.1560285699@sss.pgh.pa.us>
	<20190614095546.GA15107@msg.df7cb.de>
	<26948.1560517875@sss.pgh.pa.us>

>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:

 >>> Anyway, moving on to the question of what should we do about this,
 >>> I don't really have anything better to offer than back-patching
 >>> 23bd3cec6.

 >> The PG12 behavior seems sane, so +1.

 Tom> OK, I'll make that happen.

This isn't good enough, because it still picks "UCT" on a system with no
/etc/localtime and no TZ variable. Testing on HEAD as of 3da73d683 (on
FreeBSD, but it'll be the same anywhere else):

% ls -l /etc/*time*
ls: /etc/*time*: No such file or directory

% env -u TZ bin/initdb -D data -E UTF8 --no-locale
[...]
selecting default timezone ... UCT

We need to absolutely prefer UTC over UCT if both match.

-- 
Andrew (irc:RhodiumToad)





view thread (74+ messages)  latest in thread

Message-ID: <87ef3w3u8a.fsf@news-spur.riddles.org.uk>
Permalink:  ../87ef3w3u8a.fsf@news-spur.riddles.org.uk/
Also on:    postgresql.org/message-id/87ef3w3u8a.fsf@news-spur.riddles.org.uk

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@tao11.riddles.org.uk, tgl@sss.pgh.pa.us, myon@debian.org, pgsql-hackers@postgresql.org
  Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
  In-Reply-To: <87ef3w3u8a.fsf@news-spur.riddles.org.uk>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox