pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Stephen Frost <sfrost@snowman.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Date: Thu, 20 Jun 2019 20:19:24 +0100
Message-ID: <87y31wytdl.fsf@news-spur.riddles.org.uk> (raw)
In-Reply-To: <20190620182406.GD2480@tamriel.snowman.net>
References: <20190620161400.6wtuybv64ihnfy6d@alap3.anarazel.de>
	<20190620172838.GA21945@alvherre.pgsql>
	<CA+TgmobK3TVoxNJ0vCwvLcAjjaLvMLFWcbEpWA042bT9VdVWfQ@mail.gmail.com>
	<20190620182406.GD2480@tamriel.snowman.net>

>>>>> "Stephen" == Stephen Frost <sfrost@snowman.net> writes:

 Stephen> In the situation that started this discussion, a change had
 Stephen> already been made and it was only later realized that it
 Stephen> caused a regression.

Just to keep the facts straight:

The regression was introduced by importing tzdb 2019a (in late April)
into the previous round of point releases; the change in UTC behaviour
was not mentioned in the commit and presumably didn't show up on
anyone's radar until there were field complaints (which didn't reach our
mailing lists until Jun 4 as far as I know).

Tom's "fix" of backpatching 23bd3cec6 (which happened on Friday 14th)
addressed only a subset of cases, as far as I know working only on Linux
(the historical convention has always been for /etc/localtime to be a
copy of a zonefile, not a symlink to one). I only decided to write (and
if need be commit) my own followup fix after confirming that the bug was
unfixed in a default FreeBSD install when set to UTC, and there was a
good chance that a number of other less-popular platforms were affected
too.

 Stephen> Piling on to that, the regression was entwined with other
 Stephen> important changes that we wanted to include in the release.

I'm not sure what you're referring to here?

-- 
Andrew (irc:RhodiumToad)





view thread (74+ messages)  latest in thread

Message-ID: <87y31wytdl.fsf@news-spur.riddles.org.uk>
Permalink:  ../87y31wytdl.fsf@news-spur.riddles.org.uk/
Also on:    postgresql.org/message-id/87y31wytdl.fsf@news-spur.riddles.org.uk

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@tao11.riddles.org.uk, sfrost@snowman.net, robertmhaas@gmail.com, alvherre@2ndquadrant.com, andres@anarazel.de, tgl@sss.pgh.pa.us, myon@debian.org, pgsql-hackers@postgresql.org
  Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
  In-Reply-To: <87y31wytdl.fsf@news-spur.riddles.org.uk>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox