From: Peter Eisentraut <peter@eisentraut.org>
To: Alexander Korotkov <akorotkov@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add the MODE option to the WAIT FOR LSN command
Date: Mon, 19 Jan 2026 17:26:42 +0100
Message-ID: <8d72a2b3-7423-4a15-a981-e130bf60b1a6@eisentraut.org> (raw)
In-Reply-To: <E1vcoog-004gOI-2D@gemulon.postgresql.org>
References: <E1vcoog-004gOI-2D@gemulon.postgresql.org>
On 05.01.26 18:56, Alexander Korotkov wrote:
> Add the MODE option to the WAIT FOR LSN command
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/49a181b5d634340fcfb7c762c387c03f6405367e
>
> Modified Files
> --------------
> doc/src/sgml/ref/wait_for.sgml | 213 +++++++++++++----
> src/backend/access/transam/xlog.c | 22 +-
> src/backend/commands/wait.c | 174 ++++++++++++--
> src/backend/replication/walreceiver.c | 18 ++
> src/test/recovery/t/049_wait_for_lsn.pl | 411 +++++++++++++++++++++++++++++---
> 5 files changed, 741 insertions(+), 97 deletions(-)
This patch adds several instances in src/backend/commands/wait.c where
an elog(ERROR) is followed immediately by pg_unreachable(). I think
this is redundant. I think this pattern has been used historically in
functions that return non-void where the elog(ERROR) is the last call,
to avoid warnings about a missing return. But in this case, the
function returns void. Check please if this is really necessary or just
copy-and-pasted.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter@eisentraut.org, akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add the MODE option to the WAIT FOR LSN command
In-Reply-To: <8d72a2b3-7423-4a15-a981-e130bf60b1a6@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox