pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date: Sat, 04 Jan 2020 20:57:28 -0500
Message-ID: <912.1578189448@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-Wz=mJPd5cZwUdHGQ5sQsz6X58DivewER_WQ2+bx_ZU6yGw@mail.gmail.com>
References: <20200103170226.GB32629@msg.df7cb.de>
	<26339.1578072930@sss.pgh.pa.us>
	<20200103174839.GD32629@msg.df7cb.de>
	<CA+TgmoZsPe_G1ssO6KVPqbMQHDEz=vHPQH1jxaSjpG_QxM7wUg@mail.gmail.com>
	<CAH2-WznPzfWHu8PQwv1Qjpf4wQVPaaWpoO5NunFz9zsYKB4uJA@mail.gmail.com>
	<22669.1578104202@sss.pgh.pa.us>
	<CAH2-WznyU3QxzRr12W_tJAzjwM9qd6bh_ZGx3Xupk3RqE1t72A@mail.gmail.com>
	<25298.1578106280@sss.pgh.pa.us>
	<CAH2-Wzkq4OELzn3yZvuqsPuso5JfSXdaD+yW=1VMz2YpXTBYxA@mail.gmail.com>
	<CAH2-Wzk3xfc53A0KZRe4Xu9TALRU=HSfSVZqx3jBuws08mG-ew@mail.gmail.com>
	<3055.1578115809@sss.pgh.pa.us>
	<CAH2-Wz=CtOruqXPd3naWXNiQ0WvLSFnCDYmSDWy0hKiLrppXDQ@mail.gmail.com>
	<8038.1578119995@sss.pgh.pa.us>
	<CAH2-Wz=f4B9+Ob-51-5z9G8a9LmztNpgo0YbKuTjxus3kFjpCg@mail.gmail.com>
	<9256.1578121229@sss.pgh.pa.us>
	<25739.1578161968@sss.pgh.pa.us>
	<CAH2-WzkHftVLq1BzbJyXtSD0nf7HC8pAa8UYZwvL4nkSOv1x1A@mail.gmail.com>
	<22817.1578167447@sss.pgh.pa.us>
	<CAH2-Wz=4U_qKeLjN2FnLmSON8B5DgpMNXRdR4mLzgZjdpaMfUg@mail.gmail.com>
	<25068.1578181174@s! ss.pgh.pa.us>
	<CAH2-WzkqStzPVGCQXdd428GEUCs_VGc9kY_VhcCVt6bKNEc1zQ@mail.gmail.com>
	<26857.1578183240@sss.pgh.pa.us>
	<CAH2-Wz=mJPd5cZwUdHGQ5sQsz6X58DivewER_WQ2+bx_ZU6yGw@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> I've found the actual problem -- it's my ~/.inputrc. Which is read in by
> libreadline at some point (determined this using ltrace).

Ah-hah!

So what we really want here, I guess, is for the test script to suppress
reading of ~/.inputrc, on the same principle that it suppresses reading
of ~/.psqlrc.  A quick look at the readline docs suggests that the
best way to do that would be to set envar INPUTRC to /dev/null --- could
you confirm that that works for you?

> Once I comment out the following two lines from ~/.inputrc, everything
> works fine on
> HEAD + HEAD-unset-TERM-in-tab-completion-test.patch:
> set colored-completion-prefix on
> set colored-stats on

Hm.  I wonder how it is that that leads to ignoring the TERM environment?
Still, it's just an academic point if we can suppress reading the file.

			regards, tom lane





view thread (64+ messages)  latest in thread

Message-ID: <912.1578189448@sss.pgh.pa.us>
Permalink:  ../912.1578189448@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/912.1578189448@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, robertmhaas@gmail.com, myon@debian.org, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
  In-Reply-To: <912.1578189448@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox