pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.
Date: Sat, 15 Aug 2020 16:39:05 -0400
Message-ID: <921383.1597523945@sss.pgh.pa.us> (raw)
In-Reply-To: <E1k6zqo-0008V3-U7@gemulon.postgresql.org>
References: <E1k6zqo-0008V3-U7@gemulon.postgresql.org>

Noah Misch <noah@leadboat.com> writes:
> Prevent concurrent SimpleLruTruncate() for any given SLRU.

I find it fairly scary that you've changed enum LockTagType in the
back branches.  Are we quite certain that no extensions have compiled-in
values of that enum?

Safer from an ABI standpoint would be to add the new value at the end,
at least in the back branches.

			regards, tom lane





view thread (9+ messages)  latest in thread

Message-ID: <921383.1597523945@sss.pgh.pa.us>
Permalink:  ../921383.1597523945@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/921383.1597523945@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.
  In-Reply-To: <921383.1597523945@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox