pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix more holes with SLRU code in need of int64 for segment numbe
Date: Wed, 7 Aug 2024 11:07:13 +0200
Message-ID: <92fe572d-638e-4162-aef6-1c42a2936f25@eisentraut.org> (raw)
In-Reply-To: <E1sXTMM-001MoF-2q@gemulon.postgresql.org>
References: <E1sXTMM-001MoF-2q@gemulon.postgresql.org>

On 27.07.24 00:24, Michael Paquier wrote:
> Fix more holes with SLRU code in need of int64 for segment numbers
> 
> This is a continuation of 3937cadfd438, taking care of more areas I have
> managed to miss previously.
> 
> Reported-by: Noah Misch
> Reviewed-by: Noah Misch
> Discussion: https://postgr.es/m/20240724130059.1f.nmisch@google.com
> Backpatch-through: 17
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/c9e24573905bef7fc3e4efb02bdb4d0cc8e43c51

I don't understand this patch.  The previous patches that this 
references changed various variables to int64 and made adjustments 
following from that.  But this patch takes variables and function 
results that are of type int and casts them to unsigned long long before 
printing.  I don't see what that accomplishes, and it's not clear based 
on just the explanation that this is a continuation of a previous patch 
that doesn't do that.  Is there a plan to change these things to int64 
as well at some point?







view thread (18+ messages)  latest in thread

Message-ID: <92fe572d-638e-4162-aef6-1c42a2936f25@eisentraut.org>
Permalink:  ../92fe572d-638e-4162-aef6-1c42a2936f25@eisentraut.org/
Also on:    postgresql.org/message-id/92fe572d-638e-4162-aef6-1c42a2936f25@eisentraut.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, michael@paquier.xyz
  Subject: Re: pgsql: Fix more holes with SLRU code in need of int64 for segment numbe
  In-Reply-To: <92fe572d-638e-4162-aef6-1c42a2936f25@eisentraut.org>
  References: <E1sXTMM-001MoF-2q@gemulon.postgresql.org> <92fe572d-638e-4162-aef6-1c42a2936f25@eisentraut.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox