agora inbox for pgsql-committers@postgresql.org  

help / color / mirror / Atom feed

From: Daniel Gustafsson <dgustafsson@postgresql.org>
To: Aleksander Alekseev <aleksander@tigerdata.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Online enabling and disabling of data checksums
Date: Mon, 6 Apr 2026 16:57:43 +0200
Message-ID: <97C12A9C-D34F-42BA-936A-32C4E444B500@postgresql.org> (raw)
In-Reply-To: <CAJ7c6TPRTnQFXXX1CRcYoTLXw2swtDH==uSz1MYoMKdLrKZHjA@mail.gmail.com>
References: <E1w8lyI-002o2A-2f@gemulon.postgresql.org>
	<CAJ7c6TPRTnQFXXX1CRcYoTLXw2swtDH==uSz1MYoMKdLrKZHjA@mail.gmail.com>

> On 6 Apr 2026, at 16:39, Aleksander Alekseev <aleksander@tigerdata.com> wrote:
> 
> Hi Daniel,
> 
>> Online enabling and disabling of data checksums
>> 
>> [...]
> 
> I noticed a little mistake:

Thanks for looking!

> ```
> /*
> * Await state transition to "on" in all backends. When done we know that
> * data data checksums are both written and verified in all backends.
> */
> ```
> 
> The word "data" is repeated twice.

Ugh.

> Also there are inconsistencies in the way
> XLogCtlData->data_checksum_version,
> ControlFileData->data_checksum_version and certain variables are
> assigned. Sometimes a hardcoded 0 is used and sometimes
> PG_DATA_CHECKSUM_OFF. I suggest using values of the enum
> ChecksumStateType for readability / consistency.

PG_DATA_CHECKSUM_OFF didn't exist until quite late in the lifetime of the
patch, and clearly not all uses of 0 were ported over.

> Here are corresponding patches.

I will take another look later today when I have more time, and commit them.

--
Daniel Gustafsson

view thread (3+ messages)

Message-ID: <97C12A9C-D34F-42BA-936A-32C4E444B500@postgresql.org>
Permalink:  ../97C12A9C-D34F-42BA-936A-32C4E444B500@postgresql.org/
Also on:    postgresql.org/message-id/97C12A9C-D34F-42BA-936A-32C4E444B500@postgresql.org

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: dgustafsson@postgresql.org, aleksander@tigerdata.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Online enabling and disabling of data checksums
  In-Reply-To: <97C12A9C-D34F-42BA-936A-32C4E444B500@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox