public inbox for [email protected]
help / color / mirror / Atom feedFrom: Dmitry Dolgov <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Christoph Berg <[email protected]>
Cc: PostgreSQL Developers <[email protected]>
Cc: Sami Imseih <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Subject: Re: Squash constant lists in query jumbling by default
Date: Tue, 25 Mar 2025 21:05:44 +0100
Message-ID: <CA+q6zcU+MF8veyyXeh3m1+y2Ti7ggtK8gsN_NpHzN-ctF_xXEg@mail.gmail.com> (raw)
In-Reply-To: <CA+q6zcVTK-3C-8NWV1oY2NZrvtnMCDqnyYYyk1T7WMUG65MeOQ@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CA+q6zcVTK-3C-8NWV1oY2NZrvtnMCDqnyYYyk1T7WMUG65MeOQ@mail.gmail.com>
On Tue, Mar 25, 2025, 7:40 PM Dmitry Dolgov <[email protected]> wrote:
>
>>> On Tue, Mar 25, 2025, 6:28 PM Álvaro Herrera <[email protected]>
> wrote:
>
> On 2025-Mar-25, Tom Lane wrote:
>
> > If this GUC sticks around, it should be at least PGC_SUSET (on
>
> > the analogy of compute_query_id) to make it harder to break
>
> > pg_stat_statements that way.
>
>
> I have no problem making it superuser-only, and I can see making "on" be
>
> the default. I am not opposed to removing it completely either, if we
>
> really think that the current behavior is no longer useful for anybody.
>
>
> I'm in favor of removing the GUC of course, but if memory serves there
> were some folks in the patch discussion thread, who claimed they would
> need to be able to keep non-squashed behavior. I don't recall if there were
> particular arguments to support that, will try to find those messages
> again.
>
Nevermind, I've checked it out -- I think the case I had in mind [1] in fact
supports GUC removal:
> If anyone subtly changes jumbling logic when the extension is
active, the instance could get huge performance issues.
[1]:
https://www.postgresql.org/message-id/b8721722-a73e-0ee9-6513-425e9c88d92f%40postgrespro.ru
>
view thread (10+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Squash constant lists in query jumbling by default
In-Reply-To: <CA+q6zcU+MF8veyyXeh3m1+y2Ti7ggtK8gsN_NpHzN-ctF_xXEg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox