public inbox for [email protected]
help / color / mirror / Atom feedpgsql: Stablize tests added in 3abe9dc188.
2+ messages / 2 participants
[nested] [flat]
* pgsql: Stablize tests added in 3abe9dc188.
@ 2025-03-28 05:48 Amit Kapila <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: Amit Kapila @ 2025-03-28 05:48 UTC (permalink / raw)
To: [email protected]
Stablize tests added in 3abe9dc188.
The problem is that after the ALTER SUBSCRIPTION tap_sub SET PUBLICATION
command, we didn't wait for the new walsender to start on the publisher.
Immediately after ALTER, we performed Insert and expected it to replicate.
However, the replication could start from a point after the INSERT location,
and as the subscription isn't copying initial data, we could miss such an
Insert.
The fix is to wait for connection to be established between publisher and
subscriber before starting DML operations that are expected to replicate.
As per CI.
Reported-by: Andres Freund <[email protected]>
Author: Hayato Kuroda <[email protected]>
Discussion: https://postgr.es/m/CALDaNm2ms1deM5EYNLFEfESv_Kw=Y4AiTB0LP=qGS-UpFwGbPg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/474d7a1fd858d5ee138cf4504dcd93a9a3123a7d
Modified Files
--------------
src/test/subscription/t/007_ddl.pl | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: pgsql: Stablize tests added in 3abe9dc188.
@ 2025-03-28 11:50 Amit Kapila <[email protected]>
parent: Amit Kapila <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Amit Kapila @ 2025-03-28 11:50 UTC (permalink / raw)
To: Amit Kapila <[email protected]>; +Cc: [email protected]
On Fri, Mar 28, 2025 at 11:18 AM Amit Kapila <[email protected]> wrote:
>
> Stablize tests added in 3abe9dc188.
>
> The problem is that after the ALTER SUBSCRIPTION tap_sub SET PUBLICATION
> command, we didn't wait for the new walsender to start on the publisher.
> Immediately after ALTER, we performed Insert and expected it to replicate.
> However, the replication could start from a point after the INSERT location,
> and as the subscription isn't copying initial data, we could miss such an
> Insert.
>
> The fix is to wait for connection to be established between publisher and
> subscriber before starting DML operations that are expected to replicate.
>
> As per CI.
>
> Reported-by: Andres Freund <[email protected]>
> Author: Hayato Kuroda <[email protected]>
> Discussion: https://postgr.es/m/CALDaNm2ms1deM5EYNLFEfESv_Kw=Y4AiTB0LP=qGS-UpFwGbPg@mail.gmail.com
>
By mistake, I added a wrong discussion link. The correct one is
https://postgr.es/m/ksxbayuk5hgqdsryjxqkbnjyvk6amd2jf5tui565ex6vazglls@jva4njirno4u
--
With Regards,
Amit Kapila.
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2025-03-28 11:50 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-03-28 05:48 pgsql: Stablize tests added in 3abe9dc188. Amit Kapila <[email protected]>
2025-03-28 11:50 ` Amit Kapila <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox