From: Amit Kapila <amit.kapila16@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: YA race condition in 001_stream_rep.pl (was Re: pgsql: Allow using the updated tuple while moving it to a different par)
Date: Sun, 15 Jul 2018 16:39:50 +0530
Message-ID: <CAA4eK1LHrn2TNXUU7n-uMENBxkgepe15DG8+eGehG+eWVKF7ag@mail.gmail.com> (raw)
In-Reply-To: <1922.1531592205@sss.pgh.pa.us>
References: <E1fdW6s-00054K-QA@gemulon.postgresql.org>
<20180712075909.GG7352@paquier.xyz>
<CAA4eK1L7T-CGTLM+hUq=zGUUaN28Yk0nzWjm0MceO7y9xA5Bhg@mail.gmail.com>
<11887.1531432634@sss.pgh.pa.us>
<1922.1531592205@sss.pgh.pa.us>
On Sat, Jul 14, 2018 at 11:46 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wrote:
>
> I can reproduce the failure pretty reliably with a hack like the one
> attached, which makes it unlikely that the walreceiver will send a
> feedback message instantly when it gets the SIGHUP.
>
> So the issue boils down to this: the test script is, effectively,
> assuming that it's guaranteed that the walreceiver will send a feedback
> message before it shuts down; but there is no such guarantee. Is this
> a bug in the test script, or a bug in the walreceiver logic? I can
> see the value of having such a guarantee, but I also think it would be
> nigh impossible to make it a bulletproof guarantee. We could perhaps
> add "XLogWalRcvSendHSFeedback(true)" somewhere closer to process exit,
> but that might add more failure modes than it removes.
>
> Or we could change the test script to wait for feedback before it
> issues the shutdown, but then I think the test is a bit pointless.
>
Currently, neither the code nor our documentation suggests that we can
expect HSFeedback before the shutdown, so it is better to adjust the
test. If the sole purpose of the test is to test feedback after
shutdown, then it is worth considering to remove the test altogether.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: amit.kapila16@gmail.com, tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: YA race condition in 001_stream_rep.pl (was Re: pgsql: Allow using the updated tuple while moving it to a different par)
In-Reply-To: <CAA4eK1LHrn2TNXUU7n-uMENBxkgepe15DG8+eGehG+eWVKF7ag@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox