public inbox for [email protected]  

help / color / mirror / Atom feed
From: Sami Imseih <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Christoph Berg <[email protected]>
Cc: [email protected]
Cc: Michael Paquier <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: Dmitry Dolgov <[email protected]>
Subject: Re: Squash constant lists in query jumbling by default
Date: Tue, 25 Mar 2025 12:55:58 -0500
Message-ID: <CAA5RZ0v5VqUo_ew-fNA1HDF4Lo=7UtEyoT_SYOPjYFcjmDfE2Q@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

> > If this GUC sticks around, it should be at least PGC_SUSET (on
> > the analogy of compute_query_id) to make it harder to break
> > pg_stat_statements that way.
>
> I have no problem making it superuser-only, and I can see making "on" be
> the default.  I am not opposed to removing it completely either, if we
> really think that the current behavior is no longer useful for anybody.

I am in favor of complete removal. [1] will change the behavior of table
jumbling without introducing a GUC, and I don't think we should introduce
a GUC for the squash values case either. Why one behavior change is configurable
while the other is not? seems confusing, IMO.

Also, as a matter of principle, it seems most are favoring not
introducing GUCs to
configure queryId behavior. I agree.

[1] https://www.postgresql.org/message-id/flat/CAA5RZ0uNofEXfEfNw3uRN3D3oXkFPQ_s%2BhuLLHMKR_%2BMCk8RPQ%4...

--
Sami Imseih
Amazon Web Services (AWS)





view thread (10+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Squash constant lists in query jumbling by default
  In-Reply-To: <CAA5RZ0v5VqUo_ew-fNA1HDF4Lo=7UtEyoT_SYOPjYFcjmDfE2Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox