public inbox for [email protected]  

help / color / mirror / Atom feed

From: Masahiko Sawada <[email protected]>
To: David Rowley <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p
Date: Tue, 11 Mar 2025 21:56:14 -0700
Message-ID: <CAD21AoDQJdQG3V3zvH7x9rEF97E8VD5OarArfpY+f4bEK5wNkw@mail.gmail.com> (raw)
In-Reply-To: <CAApHDvqrhFfnetbcwgGkJ=z63T8HfQ_OyP=vX8BYiXyxFKt67w@mail.gmail.com>
References: <[email protected]>
	<CAApHDvqrhFfnetbcwgGkJ=z63T8HfQ_OyP=vX8BYiXyxFKt67w@mail.gmail.com>

On Tue, Mar 11, 2025 at 7:08 PM David Rowley <[email protected]> wrote:
>
> On Wed, 12 Mar 2025 at 05:57, Masahiko Sawada <[email protected]> wrote:
> > contrib/pg_logicalinspect/pg_logicalinspect.c      | 55 ++++++++++++---
>
> This introduces a new compiler warning for compilers that don't know
> the ereport(ERROR) does not return.
>
> The attached is enough to fix it.

Thank you for the report. Can we generate the warning using some gcc's
warning flags? I'd like to add a check to my personal pre-commit test.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

view thread (16+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: pg_logicalinspect: Fix possible crash when passing a directory p
  In-Reply-To: <CAD21AoDQJdQG3V3zvH7x9rEF97E8VD5OarArfpY+f4bEK5wNkw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox