public inbox for [email protected]
help / color / mirror / Atom feedFrom: Mark Dilger <[email protected]>
To: Peter Geoghegan <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: Improve nbtree skip scan primitive scan scheduling.
Date: Wed, 30 Apr 2025 13:10:55 -0700
Message-ID: <CAHgHdKsn2W=gPBmj7p6MjQFvxB+zZDBkwTSg0o3f5Hh8rkRrsA@mail.gmail.com> (raw)
In-Reply-To: <CAH2-WzmDF0Rcnvi2vhhYwLdF5bcs=8+rvScXWieBVkR2kezn6Q@mail.gmail.com>
References: <[email protected]>
<CAHgHdKtLFWZcjr87hMH0hYDHgcifu4Tj7iHz-xh8qsJREt5cqA@mail.gmail.com>
<CAH2-Wz=1eJZMSMoACDW2oLcxd8QUtKQS7HuYtqx98LLji+WKuQ@mail.gmail.com>
<CAHgHdKuWD2h3n6MHv2SOp8VLcKsKM1R+tLBHZrnE_WDOmDaqPg@mail.gmail.com>
<CAH2-WzmDF0Rcnvi2vhhYwLdF5bcs=8+rvScXWieBVkR2kezn6Q@mail.gmail.com>
On Mon, Apr 28, 2025 at 9:12 AM Peter Geoghegan <[email protected]> wrote:
> On Sun, Apr 27, 2025 at 1:06 PM Mark Dilger
> <[email protected]> wrote:
> > I can confirm that your patch fixes the problem, having spent some four
> hours trying to find other test cases which still fail, finding none.
>
> Great.
>
> I pushed essentially the same patch to HEAD just now.
>
A similar assertion can still be reached on HEAD using the attached (rather
contrived) regression test as of f60420cff66a9089a9b431f9c07f4a29aae4990a:
TRAP: failed Assert("sktrig_required"), File: "nbtutils.c", Line: 1861,
PID: 93648
0 postgres 0x0000000100d1b0e0
ExceptionalCondition + 108
1 postgres 0x00000001008b7658
_bt_advance_array_keys + 3828
2 postgres 0x00000001008b5dc0
_bt_check_compare + 372
3 postgres 0x00000001008b58ac _bt_checkkeys +
200
4 postgres 0x00000001008b1400 _bt_readpage +
764
5 postgres 0x00000001008b0454 _bt_readnextpage
+ 1260
6 postgres 0x00000001008b0ab0 _bt_next + 76
7 postgres 0x00000001008ac644 btgettuple + 136
8 postgres 0x000000010089dcdc
index_getnext_tid + 68
9 postgres 0x0000000100a297a0 IndexOnlyNext +
228
10 postgres 0x0000000100a0db2c ExecScan + 228
11 postgres 0x0000000100a39088 ExecSort + 536
12 postgres 0x0000000100a03c68
standard_ExecutorRun + 312
13 postgres 0x0000000100be5fb8 PortalRunSelect
+ 236
14 postgres 0x0000000100be5bd4 PortalRun + 492
15 postgres 0x0000000100be4b18
exec_simple_query + 1292
16 postgres 0x0000000100be1d1c PostgresMain +
1388
17 postgres 0x0000000100bdd9a8
BackendInitialize + 0
18 postgres 0x0000000100b36dd8
postmaster_child_launch + 372
19 postgres 0x0000000100b3b03c ServerLoop + 4948
20 postgres 0x0000000100b39360
InitProcessGlobals + 0
21 postgres 0x0000000100a58c00 help + 0
22 dyld 0x000000018eb17154 start + 2476
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachments:
[application/octet-stream] _skipscan.sql (7.7K, 3-_skipscan.sql)
download
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgsql: Improve nbtree skip scan primitive scan scheduling.
In-Reply-To: <CAHgHdKsn2W=gPBmj7p6MjQFvxB+zZDBkwTSg0o3f5Hh8rkRrsA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox