public inbox for [email protected]  

help / color / mirror / Atom feed

From: Etsuro Fujita <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Etsuro Fujita <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: postgres_fdw: Inherit the local transaction's access/deferrable
Date: Tue, 3 Jun 2025 19:45:34 +0900
Message-ID: <CAPmGK17Vf4fWt=+kCZ8V3JP7jO6iMrUze7TjOVtGzZwNbevnwg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>

On Mon, Jun 2, 2025 at 12:33 PM Michael Paquier <[email protected]> wrote:
> On Mon, Jun 02, 2025 at 12:03:50PM +0900, Fujii Masao wrote:
> > I'm not sure this change should be considered a bug fix,
> > since the current behavior of postgres_fdw with a local read-only
> > transaction isn't clearly documented. Some users might see this
> > as a behavioral change rather than a fix. Anyway if we go with it,
> > shouldn't we document the change in the v18 release notes?
>
> After going through the thread and the commit, I have to admit that I
> was surprised to see this applied on HEAD now that we are in feature
> freeze.  This is a behavior change.  Perhaps this could be done once
> v19 happens, still it's rather unclear if the new behavior is better
> than the previous one.

No, this is a fix, not a feature, as discussed in the thread; as
mentioned in the commit message, the previous version of postgres_fdw
could cause surprising behaviors that would never happen in normal
cases where a read-only and/or deferrable transaction only
accesses/modifies data on the local server, so this commit fixes those
behaviors.  But yes, it makes a behavior change, so I think it’s a
good idea to add a note about that to the v18 release notes, as
proposed by Fujii-san.

Thank you for the comments!

Best regards,
Etsuro Fujita

view thread (12+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: postgres_fdw: Inherit the local transaction's access/deferrable
  In-Reply-To: <CAPmGK17Vf4fWt=+kCZ8V3JP7jO6iMrUze7TjOVtGzZwNbevnwg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox