From: Alexander Korotkov <aekorotkov@gmail.com>
To: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: akorotkov@postgresql.org
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add TAP tests for timeouts
Date: Fri, 15 Mar 2024 13:30:28 +0200
Message-ID: <CAPpHfdvAFor_8cftdNtXvnDAyVmv77AwtLGyEa+Gb5FVMbjZ6A@mail.gmail.com> (raw)
In-Reply-To: <91C963B5-63CC-4FAE-9119-E226CF84112A@yandex-team.ru>
References: <E1rkjDR-003kjB-St@gemulon.postgresql.org>
<20240315.104235.1835366724413653745.horikyota.ntt@gmail.com>
<ZfPchPC6oNN71X2J@paquier.xyz>
<2D5B6D1F-11D2-4306-B006-4FE53D5F0E6A@yandex-team.ru>
<ZfP8St9syoccloLg@paquier.xyz>
<CAPpHfdsp6s6yN8XUV6Ke_1SO7iKq6CWa2g2qO7J1T3E1o+a=nA@mail.gmail.com>
<91C963B5-63CC-4FAE-9119-E226CF84112A@yandex-team.ru>
On Fri, Mar 15, 2024 at 1:27 PM Andrey M. Borodin <x4mmm@yandex-team.ru> wrote:
>
> > On 15 Mar 2024, at 15:44, Alexander Korotkov <aekorotkov@gmail.com> wrote:
> >
> > We loop in the interrupt checking, given that the injection point handler checks for interrupts internally. I propose to unset the timeout flag before the injection point (see the attached patch).
>
> Oh, cool.
> As far as I understand, this is only necessary for the test with injection point.
> So, maybe unset it only when injection points are enabled? Something like this is already used in GIN.
>
> #ifdef USE_INJECTION_POINTS
> ....
> #endif
Maybe, but do you see any negative side effects of the unconditionally
unset of flags? If not, I would prefer to keep the code simple.
------
Regards,
Alexander Korotkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: aekorotkov@gmail.com, x4mmm@yandex-team.ru, michael@paquier.xyz, horikyota.ntt@gmail.com, akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add TAP tests for timeouts
In-Reply-To: <CAPpHfdvAFor_8cftdNtXvnDAyVmv77AwtLGyEa+Gb5FVMbjZ6A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox