public inbox for [email protected]
help / color / mirror / Atom feedFrom: Alexander Korotkov <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: Disable logical decoding after REPACK (CONCURRENTLY)
Date: Wed, 27 May 2026 23:08:41 +0300
Message-ID: <CAPpHfdvEoXXsesebHHDTB2w9U73oS6h_n+uR027xobzLJsDwng@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
Hi!
On Wed, May 27, 2026 at 9:14 PM Álvaro Herrera <[email protected]> wrote:
> Disable logical decoding after REPACK (CONCURRENTLY)
>
> REPACK (CONCURRENTLY) uses a temporary logical replication slot, which
> is dropped once done, but it wasn't calling RequestDisableLogicalDecoding(),
> leaving effective_wal_level stuck at 'logical'.
>
> Fix by adding a Boolean flag to ReplicationSlotDropAcquired() to have it
> request to disable logical decoding, and passing it as true on REPACK.
> Other callers of that function preserve their existing behavior.
>
> Author: Imran Zaheer <[email protected]>
> Reviewed-by: shveta malik <[email protected]>
> Discussion: https://postgr.es/m/CA+UBfaktds57dw2M8BEv_kS-=ixph3w+3MxKixtaDQMi_k7Ybg@mail.gmail.com
This seams to cause buildfarm failures, for instance
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=loach&dt=2026-05-27%2018%3A25%3A00
------
Regards,
Alexander Korotkov
Supabase
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: pgsql: Disable logical decoding after REPACK (CONCURRENTLY)
In-Reply-To: <CAPpHfdvEoXXsesebHHDTB2w9U73oS6h_n+uR027xobzLJsDwng@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox