pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alexander Korotkov <aekorotkov@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Korotkov <akorotkov@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reorder actions in ProcArrayApplyRecoveryInfo()
Date: Fri, 19 Jan 2024 18:18:50 +0200
Message-ID: <CAPpHfdvc8Kvbrx-BQ0pthTbj==YTXinMKdOyFdJYesf4s9uwaw@mail.gmail.com> (raw)
In-Reply-To: <2621749.1705680495@sss.pgh.pa.us>
References: <E1rQqeS-002A0s-Qm@gemulon.postgresql.org>
	<2621749.1705680495@sss.pgh.pa.us>

On Fri, Jan 19, 2024 at 6:08 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Alexander Korotkov <akorotkov@postgresql.org> writes:
> > Reorder actions in ProcArrayApplyRecoveryInfo()
>
> I'm seeing this warning since this commit:
>
> procarray.c: In function 'ProcArrayApplyRecoveryInfo':
> procarray.c:1172:17: warning: declaration of 'xid' shadows a previous local [-Wshadow=compatible-local]
>    TransactionId xid = running->xids[i];
>                  ^~~
> procarray.c:1056:16: note: shadowed declaration is here
>   TransactionId xid;
>                 ^~~

Thank you for reporting.  Must be fixed in 448a3331d9.

------
Regards,
Alexander Korotkov





view thread (3+ messages)

Message-ID: <CAPpHfdvc8Kvbrx-BQ0pthTbj==YTXinMKdOyFdJYesf4s9uwaw@mail.gmail.com>
Permalink:  ../CAPpHfdvc8Kvbrx-BQ0pthTbj==YTXinMKdOyFdJYesf4s9uwaw@mail.gmail.com/
Also on:    postgresql.org/message-id/CAPpHfdvc8Kvbrx-BQ0pthTbj==YTXinMKdOyFdJYesf4s9uwaw@mail.gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: aekorotkov@gmail.com, tgl@sss.pgh.pa.us, akorotkov@postgresql.org
  Subject: Re: pgsql: Reorder actions in ProcArrayApplyRecoveryInfo()
  In-Reply-To: <CAPpHfdvc8Kvbrx-BQ0pthTbj==YTXinMKdOyFdJYesf4s9uwaw@mail.gmail.com>
  References: <E1rQqeS-002A0s-Qm@gemulon.postgresql.org> <2621749.1705680495@sss.pgh.pa.us> <CAPpHfdvc8Kvbrx-BQ0pthTbj==YTXinMKdOyFdJYesf4s9uwaw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox