pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tristan Partin <tristan@neon.tech>
To: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
Date: Fri, 01 Dec 2023 15:55:29 -0600
Message-ID: <CXDBYZZR3T3Q.3CQUPEYXLP4NL@neon.tech> (raw)
In-Reply-To: <20231129183619.3hrnwaexbrpygbxg@awork3.anarazel.de>
References: <E1r5Fwj-006RcU-Sh@gemulon.postgresql.org>
	<746ba786-85bb-d1f7-b613-57bec35c642a@dunslane.net>
	<20231129022843.6vfvgxjqpbgb62p5@awork3.anarazel.de>
	<703110e4-b495-e409-26a5-28e9fca8f3a5@dunslane.net>
	<20231129183619.3hrnwaexbrpygbxg@awork3.anarazel.de>

Commits look fine to me, but I hate the new target names... Luckily, 
I just use plain ninja, so I don't interact with that.

>  +    for name, v in targets_info_byname.items():
>  +        if len(targets_info_byname[name]) > 1:

My only comment is that you could reverse the logic and save yourself an 
indentation.

- if len(targets_info_byname[name]) > 1:
+ if len(targets_info_byname[name]) <= 1:
+     continue

But whatever you want.

-- 
Tristan Partin
Neon (https://neon.tech)





view thread (14+ messages)  latest in thread

Message-ID: <CXDBYZZR3T3Q.3CQUPEYXLP4NL@neon.tech>
Permalink:  ../CXDBYZZR3T3Q.3CQUPEYXLP4NL@neon.tech/
Also on:    postgresql.org/message-id/CXDBYZZR3T3Q.3CQUPEYXLP4NL@neon.tech

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tristan@neon.tech, andres@anarazel.de, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: meson: docs: Add {html,man} targets, rename install-doc-*
  In-Reply-To: <CXDBYZZR3T3Q.3CQUPEYXLP4NL@neon.tech>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox