pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Message improvements
11+ messages / 4 participants
[nested] [flat]
* pgsql: Message improvements
@ 2011-05-24 18:36 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 11+ messages in thread
From: Peter Eisentraut @ 2011-05-24 18:36 UTC (permalink / raw)
To: pgsql-committers
Message improvements
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/c8d45152fa04c77370fc16faf0727c0f52739f0a
Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: Message improvements
@ 2014-10-12 05:29 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 11+ messages in thread
From: Peter Eisentraut @ 2014-10-12 05:29 UTC (permalink / raw)
To: pgsql-committers
Message improvements
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/b7a08c80283c8d564933381b24c1993d49926e15
Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 2 +-
src/backend/access/transam/xlog.c | 6 +++---
src/backend/commands/dbcommands.c | 2 +-
src/backend/commands/matview.c | 2 +-
src/backend/commands/tablecmds.c | 2 +-
src/backend/commands/view.c | 2 +-
src/backend/libpq/be-secure-openssl.c | 2 +-
src/test/regress/expected/matview.out | 2 +-
8 files changed, 10 insertions(+), 10 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: Message improvements
@ 2014-10-12 05:29 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 11+ messages in thread
From: Peter Eisentraut @ 2014-10-12 05:29 UTC (permalink / raw)
To: pgsql-committers
Message improvements
Branch
------
REL9_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/7ce2a45aeb12d3d32a5b5e334f99a67264613fc1
Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 2 +-
src/backend/access/transam/xlog.c | 6 +++---
src/backend/commands/dbcommands.c | 2 +-
src/backend/commands/matview.c | 2 +-
src/backend/commands/tablecmds.c | 2 +-
src/backend/commands/view.c | 2 +-
src/backend/libpq/be-secure.c | 2 +-
src/test/regress/expected/matview.out | 2 +-
8 files changed, 10 insertions(+), 10 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: Message improvements
@ 2014-11-12 01:44 Peter Eisentraut <peter_e@gmx.net>
2014-11-12 02:26 ` Re: pgsql: Message improvements David G Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 11+ messages in thread
From: Peter Eisentraut @ 2014-11-12 01:44 UTC (permalink / raw)
To: pgsql-committers
Message improvements
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/8339f33d68e08d24eb316971a0ac73af162d52b3
Modified Files
--------------
src/backend/libpq/auth.c | 2 +-
src/backend/replication/logical/logical.c | 4 ++--
src/backend/replication/logical/reorderbuffer.c | 2 +-
src/backend/replication/logical/snapbuild.c | 17 +++++++++++------
src/backend/replication/slot.c | 6 ++----
src/backend/utils/misc/guc.c | 14 +++++++-------
6 files changed, 24 insertions(+), 21 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: pgsql: Message improvements
2014-11-12 01:44 pgsql: Message improvements Peter Eisentraut <peter_e@gmx.net>
@ 2014-11-12 02:26 ` David G Johnston <david.g.johnston@gmail.com>
0 siblings, 0 replies; 11+ messages in thread
From: David G Johnston @ 2014-11-12 02:26 UTC (permalink / raw)
To: pgsql-committers
A couple of minor observations:
The new wording for this one seems worse off:
> incomplete read from reorderbuffer spill file: read %d instead of %u bytes
The "incomplete" aspect seems to be material...the proposed wording leads
one to believe the file is unreadable for some reason and then goes on to
say that bytes were read.
how about:
incomplete read of reorderbuffer spill file: read %d of expected %u bytes
> Writes full pages to WAL when first modified after a checkpoint, even for
> a non-critical modifications.
"... even for non-critical modifications." -- drop the "a" since
modifications is plural (or make it singular)
David J.
--
View this message in context: http://postgresql.nabble.com/pgsql-Message-improvements-tp5826611p5826612.html
Sent from the PostgreSQL - committers mailing list archive at Nabble.com.
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: Message improvements
@ 2014-11-12 01:44 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 11+ messages in thread
From: Peter Eisentraut @ 2014-11-12 01:44 UTC (permalink / raw)
To: pgsql-committers
Message improvements
Branch
------
REL9_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/8fb4218ef41da0baff4909c5d74f23513bac9950
Modified Files
--------------
src/backend/libpq/auth.c | 2 +-
src/backend/replication/logical/logical.c | 4 ++--
src/backend/replication/logical/reorderbuffer.c | 2 +-
src/backend/replication/logical/snapbuild.c | 17 +++++++++++------
src/backend/replication/slot.c | 6 ++----
src/backend/utils/misc/guc.c | 12 ++++++------
6 files changed, 23 insertions(+), 20 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: Message improvements
@ 2015-11-17 03:07 Peter Eisentraut <peter_e@gmx.net>
2015-11-17 03:51 ` Re: pgsql: Message improvements Euler Taveira <euler@timbira.com.br>
0 siblings, 1 reply; 11+ messages in thread
From: Peter Eisentraut @ 2015-11-17 03:07 UTC (permalink / raw)
To: pgsql-committers
Message improvements
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/5db837d3f22960c2fdc11b390ecf3984b3e0c49e
Modified Files
--------------
src/backend/access/transam/parallel.c | 6 +++---
src/backend/access/transam/xlog.c | 27 ++++++++++++++-----------
src/backend/catalog/objectaddress.c | 4 ++--
src/backend/commands/copy.c | 2 +-
src/backend/commands/extension.c | 2 +-
src/backend/commands/tablecmds.c | 20 +++++++-----------
src/backend/commands/tablespace.c | 4 ++--
src/backend/libpq/auth.c | 3 +--
src/backend/libpq/pqcomm.c | 2 +-
src/backend/parser/parse_agg.c | 2 +-
src/backend/parser/parse_clause.c | 2 +-
src/backend/parser/parse_relation.c | 4 ++--
src/backend/postmaster/postmaster.c | 6 ++++--
src/backend/storage/lmgr/lwlock.c | 8 ++++----
src/backend/utils/adt/array_userfuncs.c | 2 +-
src/backend/utils/adt/encode.c | 4 ++--
src/backend/utils/adt/jsonb.c | 6 +++---
src/backend/utils/misc/guc.c | 6 +++---
src/backend/utils/misc/rls.c | 2 +-
src/port/win32error.c | 4 ++--
src/test/regress/expected/alter_table.out | 12 +++++------
src/test/regress/expected/insert_conflict.out | 6 +++---
src/test/regress/expected/join.out | 8 ++++----
src/test/regress/expected/jsonb.out | 2 +-
src/test/regress/expected/object_address.out | 6 +++---
src/test/regress/expected/rowsecurity.out | 10 ++++-----
26 files changed, 78 insertions(+), 82 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 11+ messages in thread
* Re: pgsql: Message improvements
2015-11-17 03:07 pgsql: Message improvements Peter Eisentraut <peter_e@gmx.net>
@ 2015-11-17 03:51 ` Euler Taveira <euler@timbira.com.br>
2015-11-17 11:56 ` Re: pgsql: Message improvements Peter Eisentraut <peter_e@gmx.net>
0 siblings, 1 reply; 11+ messages in thread
From: Euler Taveira @ 2015-11-17 03:51 UTC (permalink / raw)
To: Peter Eisentraut <peter_e@gmx.net>; pgsql-committers
On 17-11-2015 00:07, Peter Eisentraut wrote:
> Message improvements
>
inline patch 1: src/backend/commands/copy.c (+0/-0 lines) download inline-1.patch
--- a/src/backend/commands/copy.c
+++ b/src/backend/commands/copy.c
@@ -874,7 +874,7 @@ DoCopy(const CopyStmt *stmt, const char
* Re: pgsql: Message improvements
2015-11-17 03:07 pgsql: Message improvements Peter Eisentraut <peter_e@gmx.net>
2015-11-17 03:51 ` Re: pgsql: Message improvements Euler Taveira <euler@timbira.com.br>
@ 2015-11-17 11:56 ` Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 11+ messages in thread
From: Peter Eisentraut @ 2015-11-17 11:56 UTC (permalink / raw)
To: Euler Taveira <euler@timbira.com.br>; pgsql-committers
On 11/16/15 10:51 PM, Euler Taveira wrote:
> On 17-11-2015 00:07, Peter Eisentraut wrote:
>> Message improvements
>>
>
> --- a/src/backend/commands/copy.c
> +++ b/src/backend/commands/copy.c
> @@ -874,7 +874,7 @@ DoCopy(const CopyStmt *stmt, const char
> *queryString, uint64 *processed)
> if (is_from)
> ereport(ERROR,
> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> - errmsg("COPY FROM not supported with row level security."),
> + errmsg("COPY FROM not supported with row-level security."),
> errhint("Use INSERT statements instead.")));
>
> It seems you forgot to remove punctuation from errmsg.
Good catch! Fixed.
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: Message improvements
@ 2015-11-17 03:07 Peter Eisentraut <peter_e@gmx.net>
0 siblings, 0 replies; 11+ messages in thread
From: Peter Eisentraut @ 2015-11-17 03:07 UTC (permalink / raw)
To: pgsql-committers
Message improvements
Branch
------
REL9_5_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/689cabf402c33a69e595a0d25f61b1fb49fb1c78
Modified Files
--------------
src/backend/access/transam/parallel.c | 6 +++---
src/backend/access/transam/xlog.c | 27 ++++++++++++++-----------
src/backend/catalog/objectaddress.c | 4 ++--
src/backend/commands/copy.c | 2 +-
src/backend/commands/extension.c | 2 +-
src/backend/commands/tablecmds.c | 20 +++++++-----------
src/backend/commands/tablespace.c | 4 ++--
src/backend/libpq/auth.c | 3 +--
src/backend/libpq/pqcomm.c | 2 +-
src/backend/parser/parse_agg.c | 2 +-
src/backend/parser/parse_clause.c | 2 +-
src/backend/parser/parse_relation.c | 4 ++--
src/backend/postmaster/postmaster.c | 6 ++++--
src/backend/storage/lmgr/lwlock.c | 4 ++--
src/backend/utils/adt/array_userfuncs.c | 2 +-
src/backend/utils/adt/encode.c | 4 ++--
src/backend/utils/adt/jsonb.c | 6 +++---
src/backend/utils/misc/guc.c | 6 +++---
src/backend/utils/misc/rls.c | 2 +-
src/port/win32error.c | 4 ++--
src/test/regress/expected/alter_table.out | 12 +++++------
src/test/regress/expected/insert_conflict.out | 6 +++---
src/test/regress/expected/join.out | 8 ++++----
src/test/regress/expected/jsonb.out | 2 +-
src/test/regress/expected/object_address.out | 6 +++---
src/test/regress/expected/rowsecurity.out | 10 ++++-----
26 files changed, 76 insertions(+), 80 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
^ permalink raw reply [nested|flat] 11+ messages in thread
* pgsql: Message improvements
@ 2025-08-07 11:35 Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 11+ messages in thread
From: Peter Eisentraut @ 2025-08-07 11:35 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Message improvements
Backpatch of the relevant parts of commit 50fd428b2b9 for consistency.
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/be26c77ef9b8613a2583853b9dd7097c5d373f48
Modified Files
--------------
src/backend/replication/logical/slotsync.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 11+ messages in thread
end of thread, other threads:[~2025-08-07 11:35 UTC | newest]
Thread overview: 11+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2011-05-24 18:36 pgsql: Message improvements Peter Eisentraut <peter_e@gmx.net>
2014-10-12 05:29 pgsql: Message improvements Peter Eisentraut <peter_e@gmx.net>
2014-10-12 05:29 pgsql: Message improvements Peter Eisentraut <peter_e@gmx.net>
2014-11-12 01:44 pgsql: Message improvements Peter Eisentraut <peter_e@gmx.net>
2014-11-12 02:26 ` David G Johnston <david.g.johnston@gmail.com>
2014-11-12 01:44 pgsql: Message improvements Peter Eisentraut <peter_e@gmx.net>
2015-11-17 03:07 pgsql: Message improvements Peter Eisentraut <peter_e@gmx.net>
2015-11-17 03:51 ` Euler Taveira <euler@timbira.com.br>
2015-11-17 11:56 ` Peter Eisentraut <peter_e@gmx.net>
2015-11-17 03:07 pgsql: Message improvements Peter Eisentraut <peter_e@gmx.net>
2025-08-07 11:35 pgsql: Message improvements Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox