pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@postgresql.org
Subject: pgsql: Fix some bogosities in pg_dump's foreign-table support.
Date: Mon, 28 Nov 2011 17:51:58 +0000
Message-ID: <E1RV5N0-0004jw-7T@gemulon.postgresql.org> (raw)

Fix some bogosities in pg_dump's foreign-table support.

The server name for a foreign table was not quoted at need, as per report
from Ronan Dunklau.  Also, queries related to FDW options were inadequately
schema-qualified in places where the search path isn't just pg_catalog, and
were inconsistently formatted everywhere, and we didn't always check that
we got the expected number of rows from them.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/5c19c057dcdaef08b89e751f7e335cc1f6a1e21f

Modified Files
--------------
src/bin/pg_dump/pg_dump.c |   61 ++++++++++++++++++++++++++++----------------
1 files changed, 39 insertions(+), 22 deletions(-)



view thread (2+ messages)  latest in thread

Message-ID: <E1RV5N0-0004jw-7T@gemulon.postgresql.org>
Permalink:  ../E1RV5N0-0004jw-7T@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1RV5N0-0004jw-7T@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix some bogosities in pg_dump's foreign-table support.
  In-Reply-To: <E1RV5N0-0004jw-7T@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox