pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@postgresql.org
Subject: pgsql: Force pgwin32_recv into nonblock mode when called from pgstat.c.
Date: Mon, 14 May 2012 14:57:15 +0000
Message-ID: <E1STwi3-0002yh-Au@gemulon.postgresql.org> (raw)

Force pgwin32_recv into nonblock mode when called from pgstat.c.

This should get rid of the usage of pgwin32_waitforsinglesocket entirely,
and perhaps thereby remove the race condition that's evidently still
present on some versions of Windows.  The previous arrangement was a bit
unsafe anyway, since waiting at the recv() would not allow pgstat to notice
postmaster death.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/f1ca51549e9e7045a2db95a61744334f1dbb4d64

Modified Files
--------------
src/backend/postmaster/pgstat.c |   12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)



Message-ID: <E1STwi3-0002yh-Au@gemulon.postgresql.org>
Permalink:  ../E1STwi3-0002yh-Au@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1STwi3-0002yh-Au@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Force pgwin32_recv into nonblock mode when called from pgstat.c.
  In-Reply-To: <E1STwi3-0002yh-Au@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox