pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
To: pgsql-committers@postgresql.org
Subject: pgsql: Code review of recycling WAL segments in a restartpoint.
Date: Mon, 03 Jun 2013 07:08:54 +0000
Message-ID: <E1UjOsw-0000wt-MW@gemulon.postgresql.org> (raw)
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

Code review of recycling WAL segments in a restartpoint.

Seems cleaner to get the currently-replayed TLI in the same call to
GetXLogReplayRecPtr that we get the WAL position. Make it more clear in the
comment what the code does when recovery has already ended
(RecoveryInProgress() will set ThisTimeLineID in that case). Finally, make
resetting ThisTimeLineID afterwards more explicit.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/e1e2bb34f1237cbec396bcaa795f0fa955af0e72

Modified Files
--------------
src/backend/access/transam/xlog.c |   30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Message-ID: <E1UjOsw-0000wt-MW@gemulon.postgresql.org>
Permalink:  ../E1UjOsw-0000wt-MW@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1UjOsw-0000wt-MW@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: heikki.linnakangas@iki.fi
  Subject: Re: pgsql: Code review of recycling WAL segments in a restartpoint.
  In-Reply-To: <E1UjOsw-0000wt-MW@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox