pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Check for interrupts and stack overflow during rule/view dumps.
12+ messages / 1 participants
[nested] [flat]

* pgsql: Check for interrupts and stack overflow during rule/view dumps.
@ 2014-04-30 17:46  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2014-04-30 17:46 UTC (permalink / raw)
  To: pgsql-committers

Check for interrupts and stack overflow during rule/view dumps.

Since ruleutils.c recurses, it could be driven to stack overflow by
deeply nested constructs.  Very large queries might also take long
enough to deparse that a check for interrupts seems like a good idea.
Stick appropriate tests into a couple of key places.

Noted by Greg Stark.  Back-patch to all supported branches.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/0bff398761b5e6119b40550bbe3751f4194dc7a7

Modified Files
--------------
src/backend/utils/adt/ruleutils.c |   13 +++++++++++++
1 file changed, 13 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: Check for interrupts and stack overflow during rule/view dumps.
@ 2014-04-30 17:46  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2014-04-30 17:46 UTC (permalink / raw)
  To: pgsql-committers

Check for interrupts and stack overflow during rule/view dumps.

Since ruleutils.c recurses, it could be driven to stack overflow by
deeply nested constructs.  Very large queries might also take long
enough to deparse that a check for interrupts seems like a good idea.
Stick appropriate tests into a couple of key places.

Noted by Greg Stark.  Back-patch to all supported branches.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/0140bee43d55324a066a43bce63fc6ed70c305de

Modified Files
--------------
src/backend/utils/adt/ruleutils.c |   13 +++++++++++++
1 file changed, 13 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: Check for interrupts and stack overflow during rule/view dumps.
@ 2014-04-30 17:46  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2014-04-30 17:46 UTC (permalink / raw)
  To: pgsql-committers

Check for interrupts and stack overflow during rule/view dumps.

Since ruleutils.c recurses, it could be driven to stack overflow by
deeply nested constructs.  Very large queries might also take long
enough to deparse that a check for interrupts seems like a good idea.
Stick appropriate tests into a couple of key places.

Noted by Greg Stark.  Back-patch to all supported branches.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/920fbc1b4347dfca940f7aacf28d9e22294477c1

Modified Files
--------------
src/backend/utils/adt/ruleutils.c |   13 +++++++++++++
1 file changed, 13 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: Check for interrupts and stack overflow during rule/view dumps.
@ 2014-04-30 17:46  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2014-04-30 17:46 UTC (permalink / raw)
  To: pgsql-committers

Check for interrupts and stack overflow during rule/view dumps.

Since ruleutils.c recurses, it could be driven to stack overflow by
deeply nested constructs.  Very large queries might also take long
enough to deparse that a check for interrupts seems like a good idea.
Stick appropriate tests into a couple of key places.

Noted by Greg Stark.  Back-patch to all supported branches.

Branch
------
REL8_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/f49df9150b9a00f7934f025677975e2396efebcd

Modified Files
--------------
src/backend/utils/adt/ruleutils.c |   13 +++++++++++++
1 file changed, 13 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: Check for interrupts and stack overflow during rule/view dumps.
@ 2014-04-30 17:46  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2014-04-30 17:46 UTC (permalink / raw)
  To: pgsql-committers

Check for interrupts and stack overflow during rule/view dumps.

Since ruleutils.c recurses, it could be driven to stack overflow by
deeply nested constructs.  Very large queries might also take long
enough to deparse that a check for interrupts seems like a good idea.
Stick appropriate tests into a couple of key places.

Noted by Greg Stark.  Back-patch to all supported branches.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/c4252ec43cd95b20b278f023c3616eb39dcd2b8b

Modified Files
--------------
src/backend/utils/adt/ruleutils.c |   13 +++++++++++++
1 file changed, 13 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: Check for interrupts and stack overflow during rule/view dumps.
@ 2014-04-30 17:46  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2014-04-30 17:46 UTC (permalink / raw)
  To: pgsql-committers

Check for interrupts and stack overflow during rule/view dumps.

Since ruleutils.c recurses, it could be driven to stack overflow by
deeply nested constructs.  Very large queries might also take long
enough to deparse that a check for interrupts seems like a good idea.
Stick appropriate tests into a couple of key places.

Noted by Greg Stark.  Back-patch to all supported branches.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/3897ee9b1fe5000552e38b325130ece9a2dfa0d0

Modified Files
--------------
src/backend/utils/adt/ruleutils.c |   13 +++++++++++++
1 file changed, 13 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: Check for interrupts and stack overflow in TParserGet().
@ 2023-06-24 21:18  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2023-06-24 21:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Check for interrupts and stack overflow in TParserGet().

TParserGet() recurses for some token types, meaning it's possible
to drive it to stack overflow.  Since this is a minority behavior,
I chose to add the check_stack_depth() call to the two places that
recurse rather than doing it during every single call.

While at it, add CHECK_FOR_INTERRUPTS(), because this can run
unpleasantly long for long inputs.

Per bug #17995 from Zuming Jiang.  This is old, so back-patch
to all supported branches.

Discussion: https://postgr.es/m/17995-9f20ff3e6389db4c@postgresql.org

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a77d901714416f6bd4343c367585b060f385bbbc

Modified Files
--------------
src/backend/tsearch/wparser_def.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: Check for interrupts and stack overflow in TParserGet().
@ 2023-06-24 21:18  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2023-06-24 21:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Check for interrupts and stack overflow in TParserGet().

TParserGet() recurses for some token types, meaning it's possible
to drive it to stack overflow.  Since this is a minority behavior,
I chose to add the check_stack_depth() call to the two places that
recurse rather than doing it during every single call.

While at it, add CHECK_FOR_INTERRUPTS(), because this can run
unpleasantly long for long inputs.

Per bug #17995 from Zuming Jiang.  This is old, so back-patch
to all supported branches.

Discussion: https://postgr.es/m/17995-9f20ff3e6389db4c@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/691594acd67e68d903ea1b7575a7a9097772bbcb

Modified Files
--------------
src/backend/tsearch/wparser_def.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: Check for interrupts and stack overflow in TParserGet().
@ 2023-06-24 21:18  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2023-06-24 21:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Check for interrupts and stack overflow in TParserGet().

TParserGet() recurses for some token types, meaning it's possible
to drive it to stack overflow.  Since this is a minority behavior,
I chose to add the check_stack_depth() call to the two places that
recurse rather than doing it during every single call.

While at it, add CHECK_FOR_INTERRUPTS(), because this can run
unpleasantly long for long inputs.

Per bug #17995 from Zuming Jiang.  This is old, so back-patch
to all supported branches.

Discussion: https://postgr.es/m/17995-9f20ff3e6389db4c@postgresql.org

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4c61afa47c618a11ad78b91dcd083e73b6332e82

Modified Files
--------------
src/backend/tsearch/wparser_def.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: Check for interrupts and stack overflow in TParserGet().
@ 2023-06-24 21:18  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2023-06-24 21:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Check for interrupts and stack overflow in TParserGet().

TParserGet() recurses for some token types, meaning it's possible
to drive it to stack overflow.  Since this is a minority behavior,
I chose to add the check_stack_depth() call to the two places that
recurse rather than doing it during every single call.

While at it, add CHECK_FOR_INTERRUPTS(), because this can run
unpleasantly long for long inputs.

Per bug #17995 from Zuming Jiang.  This is old, so back-patch
to all supported branches.

Discussion: https://postgr.es/m/17995-9f20ff3e6389db4c@postgresql.org

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c7f33a197bf26da1f7aedd8b33c1ac324bf6ff06

Modified Files
--------------
src/backend/tsearch/wparser_def.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: Check for interrupts and stack overflow in TParserGet().
@ 2023-06-24 21:18  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2023-06-24 21:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Check for interrupts and stack overflow in TParserGet().

TParserGet() recurses for some token types, meaning it's possible
to drive it to stack overflow.  Since this is a minority behavior,
I chose to add the check_stack_depth() call to the two places that
recurse rather than doing it during every single call.

While at it, add CHECK_FOR_INTERRUPTS(), because this can run
unpleasantly long for long inputs.

Per bug #17995 from Zuming Jiang.  This is old, so back-patch
to all supported branches.

Discussion: https://postgr.es/m/17995-9f20ff3e6389db4c@postgresql.org

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/b6ab18a990ffd0daa55665e3153bfed9db547fa7

Modified Files
--------------
src/backend/tsearch/wparser_def.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread

* pgsql: Check for interrupts and stack overflow in TParserGet().
@ 2023-06-24 21:18  Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 12+ messages in thread

From: Tom Lane @ 2023-06-24 21:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Check for interrupts and stack overflow in TParserGet().

TParserGet() recurses for some token types, meaning it's possible
to drive it to stack overflow.  Since this is a minority behavior,
I chose to add the check_stack_depth() call to the two places that
recurse rather than doing it during every single call.

While at it, add CHECK_FOR_INTERRUPTS(), because this can run
unpleasantly long for long inputs.

Per bug #17995 from Zuming Jiang.  This is old, so back-patch
to all supported branches.

Discussion: https://postgr.es/m/17995-9f20ff3e6389db4c@postgresql.org

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/3b4580f5ce984e8c47ed5932b196c83931c9ed8c

Modified Files
--------------
src/backend/tsearch/wparser_def.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)



^ permalink  raw  reply  [nested|flat] 12+ messages in thread


end of thread, other threads:[~2023-06-24 21:18 UTC | newest]

Thread overview: 12+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2014-04-30 17:46 pgsql: Check for interrupts and stack overflow during rule/view dumps. Tom Lane <tgl@sss.pgh.pa.us>
2014-04-30 17:46 pgsql: Check for interrupts and stack overflow during rule/view dumps. Tom Lane <tgl@sss.pgh.pa.us>
2014-04-30 17:46 pgsql: Check for interrupts and stack overflow during rule/view dumps. Tom Lane <tgl@sss.pgh.pa.us>
2014-04-30 17:46 pgsql: Check for interrupts and stack overflow during rule/view dumps. Tom Lane <tgl@sss.pgh.pa.us>
2014-04-30 17:46 pgsql: Check for interrupts and stack overflow during rule/view dumps. Tom Lane <tgl@sss.pgh.pa.us>
2014-04-30 17:46 pgsql: Check for interrupts and stack overflow during rule/view dumps. Tom Lane <tgl@sss.pgh.pa.us>
2023-06-24 21:18 pgsql: Check for interrupts and stack overflow in TParserGet(). Tom Lane <tgl@sss.pgh.pa.us>
2023-06-24 21:18 pgsql: Check for interrupts and stack overflow in TParserGet(). Tom Lane <tgl@sss.pgh.pa.us>
2023-06-24 21:18 pgsql: Check for interrupts and stack overflow in TParserGet(). Tom Lane <tgl@sss.pgh.pa.us>
2023-06-24 21:18 pgsql: Check for interrupts and stack overflow in TParserGet(). Tom Lane <tgl@sss.pgh.pa.us>
2023-06-24 21:18 pgsql: Check for interrupts and stack overflow in TParserGet(). Tom Lane <tgl@sss.pgh.pa.us>
2023-06-24 21:18 pgsql: Check for interrupts and stack overflow in TParserGet(). Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox