pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@postgresql.org
Subject: pgsql: Check for interrupts and stack overflow during rule/view dumps.
Date: Wed, 30 Apr 2014 17:46:53 +0000
Message-ID: <E1WfYar-0007No-N9@gemulon.postgresql.org> (raw)
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

Check for interrupts and stack overflow during rule/view dumps.

Since ruleutils.c recurses, it could be driven to stack overflow by
deeply nested constructs.  Very large queries might also take long
enough to deparse that a check for interrupts seems like a good idea.
Stick appropriate tests into a couple of key places.

Noted by Greg Stark.  Back-patch to all supported branches.

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/920fbc1b4347dfca940f7aacf28d9e22294477c1

Modified Files
--------------
src/backend/utils/adt/ruleutils.c |   13 +++++++++++++
1 file changed, 13 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


view thread (12+ messages)  latest in thread

Message-ID: <E1WfYar-0007No-N9@gemulon.postgresql.org>
Permalink:  ../E1WfYar-0007No-N9@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1WfYar-0007No-N9@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Check for interrupts and stack overflow during rule/view dumps.
  In-Reply-To: <E1WfYar-0007No-N9@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox