pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Move pg_test_fsync from contrib/ to src/bin/
3+ messages / 3 participants
[nested] [flat]

Commits from this thread:
  2023-11-25 6ec8262a02  C comment:  add header to pg_test_fsync.c
* pgsql: Move pg_test_fsync from contrib/ to src/bin/
@ 2015-04-20 02:39  Peter Eisentraut <peter_e@gmx.net>
  0 siblings, 1 reply; 3+ messages in thread

From: Peter Eisentraut @ 2015-04-20 02:39 UTC (permalink / raw)
  To: pgsql-committers

Move pg_test_fsync from contrib/ to src/bin/

Reviewed-by: Michael Paquier <michael.paquier@gmail.com>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/00882d9e5ce7b693aa536346f68a826064c8683a

Modified Files
--------------
contrib/Makefile                      |    1 -
contrib/pg_test_fsync/.gitignore      |    1 -
contrib/pg_test_fsync/Makefile        |   18 -
contrib/pg_test_fsync/pg_test_fsync.c |  603 ---------------------------------
doc/src/sgml/contrib.sgml             |    1 -
doc/src/sgml/filelist.sgml            |    1 -
doc/src/sgml/pgtestfsync.sgml         |  121 -------
doc/src/sgml/ref/allfiles.sgml        |    1 +
doc/src/sgml/ref/pgtestfsync.sgml     |  113 ++++++
doc/src/sgml/reference.sgml           |    1 +
src/bin/Makefile                      |    1 +
src/bin/pg_test_fsync/.gitignore      |    1 +
src/bin/pg_test_fsync/Makefile        |   27 ++
src/bin/pg_test_fsync/pg_test_fsync.c |  603 +++++++++++++++++++++++++++++++++
src/tools/msvc/Mkvcbuild.pm           |    8 +-
15 files changed, 751 insertions(+), 750 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pgsql: Move pg_test_fsync from contrib/ to src/bin/
@ 2015-04-20 05:51  Michael Paquier <michael.paquier@gmail.com>
  parent: Peter Eisentraut <peter_e@gmx.net>
  0 siblings, 1 reply; 3+ messages in thread

From: Michael Paquier @ 2015-04-20 05:51 UTC (permalink / raw)
  To: Peter Eisentraut <peter_e@gmx.net>; +Cc: pgsql-committers

On Mon, Apr 20, 2015 at 11:39 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> Move pg_test_fsync from contrib/ to src/bin/

Point of detail that I just noticed: wouldn't it be better to have a
header in pg_test_fsync.c of a shape similar to the other files. Now
there is only that:
/*
 *    pg_test_fsync.c
 *        tests all supported fsync() methods
 */
An idea what this gives as a patch is attached.
-- 
Michael

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Attachments:

20150420_pg_test_fsync_header.patch (text/x-patch, 668B) download diff --git a/src/bin/pg_test_fsync/pg_test_fsync.c b/src/bin/pg_test_fsync/pg_test_fsync.c index c842762..54e7871 100644 --- a/src/bin/pg_test_fsync/pg_test_fsync.c +++ b/src/bin/pg_test_fsync/pg_test_fsync.c @@ -1,6 +1,12 @@ -/* - * pg_test_fsync.c - * tests all supported fsync() methods +/*------------------------------------------------------------------------- + * + * pg_test_fsync --- tests all supported fsync() methods + * + * Portions Copyright (c) 1996-2015, PostgreSQL Global Development Group + * + * src/bin/pg_test_fsync/pg_test_fsync.c + * + *------------------------------------------------------------------------- */ #include "postgres_fe.h"
^ permalink raw reply [nested|flat] 3+ messages in thread

* Re: [COMMITTERS] pgsql: Move pg_test_fsync from contrib/ to src/bin/
@ 2023-11-25 16:05  Bruce Momjian <bruce@momjian.us>
  parent: Michael Paquier <michael.paquier@gmail.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Bruce Momjian @ 2023-11-25 16:05 UTC (permalink / raw)
  To: Michael Paquier <michael.paquier@gmail.com>; +Cc: Peter Eisentraut <peter_e@gmx.net>; pgsql-committers

On Mon, Apr 20, 2015 at 02:51:10PM +0900, Michael Paquier wrote:
> On Mon, Apr 20, 2015 at 11:39 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> > Move pg_test_fsync from contrib/ to src/bin/
> 
> Point of detail that I just noticed: wouldn't it be better to have a
> header in pg_test_fsync.c of a shape similar to the other files. Now
> there is only that:
> /*
>  *    pg_test_fsync.c
>  *        tests all supported fsync() methods
>  */
> An idea what this gives as a patch is attached.

This patch is old but the header is still missing, so patch applied to
master.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.





^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2023-11-25 16:05 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2015-04-20 02:39 pgsql: Move pg_test_fsync from contrib/ to src/bin/ Peter Eisentraut <peter_e@gmx.net>
2015-04-20 05:51 ` Michael Paquier <michael.paquier@gmail.com>
2023-11-25 16:05   ` Bruce Momjian <bruce@momjian.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox