pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: pgsql-committers@postgresql.org
Subject: pgsql: Desupport jsonb subscript deletion on objects
Date: Mon, 08 Jun 2015 00:46:29 +0000
Message-ID: <E1Z1lCv-00008l-2U@gemulon.postgresql.org> (raw)
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

Desupport jsonb subscript deletion on objects

Supporting deletion of JSON pairs within jsonb objects using an
array-style integer subscript allowed for surprising outcomes.  This was
mostly due to the implementation-defined ordering of pairs within
objects for jsonb.

It also seems desirable to make jsonb integer subscript deletion
consistent with the 9.4 era general purpose integer subscripting
operator for jsonb (although that operator returns NULL when an object
is encountered, while we prefer here to throw an error).

Peter Geoghegan, following discussion on -hackers.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/b81c7b4098f52e64df89efe1461ba00a54649a10

Modified Files
--------------
doc/src/sgml/func.sgml                |    5 +--
src/backend/utils/adt/jsonfuncs.c     |    5 +++
src/test/regress/expected/jsonb.out   |   56 ++-------------------------------
src/test/regress/expected/jsonb_1.out |   56 ++-------------------------------
src/test/regress/sql/jsonb.sql        |   11 +------
5 files changed, 13 insertions(+), 120 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Message-ID: <E1Z1lCv-00008l-2U@gemulon.postgresql.org>
Permalink:  ../E1Z1lCv-00008l-2U@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1Z1lCv-00008l-2U@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net
  Subject: Re: pgsql: Desupport jsonb subscript deletion on objects
  In-Reply-To: <E1Z1lCv-00008l-2U@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox