pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Improve regression test coverage of table lock modes vs permissi 5+ messages / 2 participants [nested] [flat]
* pgsql: Improve regression test coverage of table lock modes vs permissi @ 2015-07-07 21:36 Joe Conway <mail@joeconway.com> 0 siblings, 0 replies; 5+ messages in thread From: Joe Conway @ 2015-07-07 21:36 UTC (permalink / raw) To: pgsql-committers Improve regression test coverage of table lock modes vs permissions. Test the interactions with permissions and LOCK TABLE. Specifically ROW EXCLUSIVE, ACCESS SHARE, and ACCESS EXCLUSIVE modes against SELECT, INSERT, UPDATE, DELETE, and TRUNCATE permissions. Discussed by Stephen Frost and Michael Paquier, patch by the latter. Backpatch to 9.5 where matching behavior was first committed. Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/e66a45344ff33d64aa6ff50673ff9fe8577ea6db Modified Files -------------- src/test/regress/expected/privileges.out | 83 +++++++++++++++++++++++++++++ src/test/regress/sql/privileges.sql | 84 ++++++++++++++++++++++++++++++ 2 files changed, 167 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Improve regression test coverage of table lock modes vs permissi @ 2015-07-07 21:36 Joe Conway <mail@joeconway.com> 0 siblings, 0 replies; 5+ messages in thread From: Joe Conway @ 2015-07-07 21:36 UTC (permalink / raw) To: pgsql-committers Improve regression test coverage of table lock modes vs permissions. Test the interactions with permissions and LOCK TABLE. Specifically ROW EXCLUSIVE, ACCESS SHARE, and ACCESS EXCLUSIVE modes against SELECT, INSERT, UPDATE, DELETE, and TRUNCATE permissions. Discussed by Stephen Frost and Michael Paquier, patch by the latter. Backpatch to 9.5 where matching behavior was first committed. Branch ------ REL9_5_STABLE Details ------- http://git.postgresql.org/pg/commitdiff/d5f551abcf78cb4e3f6c5d195bd260893443414b Modified Files -------------- src/test/regress/expected/privileges.out | 83 +++++++++++++++++++++++++++++ src/test/regress/sql/privileges.sql | 84 ++++++++++++++++++++++++++++++ 2 files changed, 167 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Improve regression test coverage of regress.c. @ 2018-02-27 17:13 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2018-02-27 17:13 UTC (permalink / raw) To: pgsql-committers Improve regression test coverage of regress.c. It's a bit silly to have test functions that aren't tested, so test them. In passing, rename int44in/int44out to city_budget_in/_out so that they match how the regression tests use them. Also, fix city_budget_out so that it emits the format city_budget_in expects to read; otherwise we'd have dump/reload failures when testing pg_dump against the regression database. (We avoided that in the past only because no data of type city_budget was actually stored anywhere.) Discussion: https://postgr.es/m/29322.1519701006@sss.pgh.pa.us Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/be42eb9d624cc14a9326e21ec75fdc571a7cb188 Modified Files -------------- src/test/regress/expected/create_misc.out | 10 +++++++ src/test/regress/expected/create_operator.out | 8 ++++++ src/test/regress/expected/create_type.out | 13 +++++++-- src/test/regress/input/create_function_1.source | 4 +-- src/test/regress/output/create_function_1.source | 4 +-- src/test/regress/regress.c | 34 +++++++++++------------- src/test/regress/sql/create_misc.sql | 5 ++++ src/test/regress/sql/create_operator.sql | 4 +++ src/test/regress/sql/create_type.sql | 8 ++++-- 9 files changed, 63 insertions(+), 27 deletions(-) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Improve regression test coverage of expand_tuple(). @ 2018-04-14 23:02 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2018-04-14 23:02 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve regression test coverage of expand_tuple(). I was dissatisfied with the code coverage report for expand_tuple() in the wake of commit 7c44c46de: while better than no coverage at all, it was still not exercising the core function of inserting out-of-line default values, nor was the HeapTuple-output path covered. So far as I can find, the only code path that reaches the latter at present is EvalPlanQual fetches for non-locked tables. Hence, extend eval-plan-qual.spec to test cases where out-of-line defaults must be inserted into a tuple fetched from a non-locked table. Discussion: https://postgr.es/m/87woxi24uw.fsf@ansel.ydns.eu Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b39fd897e0398a6bdc6552daa7cacdf9c0e46d7e Modified Files -------------- src/test/isolation/expected/eval-plan-qual.out | 20 ++++++++++++++++++++ src/test/isolation/specs/eval-plan-qual.spec | 14 ++++++++++++++ 2 files changed, 34 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
* pgsql: Improve regression test coverage of GiST index building. @ 2022-07-30 20:22 Tom Lane <tgl@sss.pgh.pa.us> 0 siblings, 0 replies; 5+ messages in thread From: Tom Lane @ 2022-07-30 20:22 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Improve regression test coverage of GiST index building. Add a test case that exercises the "buffering build" code path. This covers almost all the non-error-case lines in gistbuild.c and gistbuildbuffers.c. Matheus Alcantara, based on earlier work by Pavel Borisov Discussion: https://postgr.es/m/3z8Fde-IHbW57a7bEZtaf19f4YOCWu67IZoWJoGW18rKD9R16ZHHchf4d7KFI3Yg7-0N4NonFuwKEgh9... Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6a1f082abac9da756d473e16238a906ca5a592dc Modified Files -------------- src/test/regress/expected/gist.out | 3 +++ src/test/regress/sql/gist.sql | 4 ++++ 2 files changed, 7 insertions(+) ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2022-07-30 20:22 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2015-07-07 21:36 pgsql: Improve regression test coverage of table lock modes vs permissi Joe Conway <mail@joeconway.com> 2015-07-07 21:36 pgsql: Improve regression test coverage of table lock modes vs permissi Joe Conway <mail@joeconway.com> 2018-02-27 17:13 pgsql: Improve regression test coverage of regress.c. Tom Lane <tgl@sss.pgh.pa.us> 2018-04-14 23:02 pgsql: Improve regression test coverage of expand_tuple(). Tom Lane <tgl@sss.pgh.pa.us> 2022-07-30 20:22 pgsql: Improve regression test coverage of GiST index building. Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox