pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@postgresql.org
Subject: pgsql: Improve regression test coverage of regress.c.
Date: Tue, 27 Feb 2018 17:13:24 +0000
Message-ID: <E1eqioe-0002Zq-4m@gemulon.postgresql.org> (raw)

Improve regression test coverage of regress.c.

It's a bit silly to have test functions that aren't tested, so test
them.

In passing, rename int44in/int44out to city_budget_in/_out so that they
match how the regression tests use them.  Also, fix city_budget_out
so that it emits the format city_budget_in expects to read; otherwise
we'd have dump/reload failures when testing pg_dump against the
regression database.  (We avoided that in the past only because no
data of type city_budget was actually stored anywhere.)

Discussion: https://postgr.es/m/29322.1519701006@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/be42eb9d624cc14a9326e21ec75fdc571a7cb188

Modified Files
--------------
src/test/regress/expected/create_misc.out        | 10 +++++++
src/test/regress/expected/create_operator.out    |  8 ++++++
src/test/regress/expected/create_type.out        | 13 +++++++--
src/test/regress/input/create_function_1.source  |  4 +--
src/test/regress/output/create_function_1.source |  4 +--
src/test/regress/regress.c                       | 34 +++++++++++-------------
src/test/regress/sql/create_misc.sql             |  5 ++++
src/test/regress/sql/create_operator.sql         |  4 +++
src/test/regress/sql/create_type.sql             |  8 ++++--
9 files changed, 63 insertions(+), 27 deletions(-)



view thread (5+ messages)  latest in thread

Message-ID: <E1eqioe-0002Zq-4m@gemulon.postgresql.org>
Permalink:  ../E1eqioe-0002Zq-4m@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1eqioe-0002Zq-4m@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Improve regression test coverage of regress.c.
  In-Reply-To: <E1eqioe-0002Zq-4m@gemulon.postgresql.org>
  References: <E1eqioe-0002Zq-4m@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox