pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@postgresql.org
Subject: pgsql: Fix ruleutils.c's dumping of whole-row Vars in ROW() and VALUES(
Date: Sun, 15 Nov 2015 19:41:46 +0000
Message-ID: <E1Zy3BK-0006n7-0F@gemulon.postgresql.org> (raw)
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

Fix ruleutils.c's dumping of whole-row Vars in ROW() and VALUES() contexts.

Normally ruleutils prints a whole-row Var as "foo.*".  We already knew that
that doesn't work at top level of a SELECT list, because the parser would
treat the "*" as a directive to expand the reference into separate columns,
not a whole-row Var.  However, Joshua Yanovski points out in bug #13776
that the same thing happens at top level of a ROW() construct; and some
nosing around in the parser shows that the same is true in VALUES().
Hence, apply the same workaround already devised for the SELECT-list case,
namely to add a forced cast to the appropriate rowtype in these cases.
(The alternative of just printing "foo" was rejected because it is
difficult to avoid ambiguity against plain columns named "foo".)

Back-patch to all supported branches.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/d33ab56b0ee3dbb5a353bf07804820f1daa199d5

Modified Files
--------------
src/backend/utils/adt/ruleutils.c         |   35 +++++++++--
src/test/regress/expected/create_view.out |   91 +++++++++++++++++++++++++++++
src/test/regress/sql/create_view.sql      |   18 ++++++
3 files changed, 139 insertions(+), 5 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


view thread (12+ messages)  latest in thread

Message-ID: <E1Zy3BK-0006n7-0F@gemulon.postgresql.org>
Permalink:  ../E1Zy3BK-0006n7-0F@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1Zy3BK-0006n7-0F@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Fix ruleutils.c's dumping of whole-row Vars in ROW() and VALUES(
  In-Reply-To: <E1Zy3BK-0006n7-0F@gemulon.postgresql.org>
  References: <E1Zy3BK-0006n7-0F@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox