pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@postgresql.org
Subject: pgsql: Add a temp-install prerequisite to "check"-like targets not havi
Date: Mon, 06 Nov 2017 03:03:54 +0000
Message-ID: <E1eBXha-00057r-0d@gemulon.postgresql.org> (raw)
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

Add a temp-install prerequisite to "check"-like targets not having one.

Makefile.global assigns this prerequisite to every target named "check",
but similar targets must mention it explicitly.  Affected targets
failed, tested $PATH binaries, or tested a stale temporary installation.
The src/test/modules examples worked properly when called as "make -C
src/test/modules/$FOO check", but "make -j" allowed the test to start
before the temporary installation was in place.  Back-patch to 9.5,
where commit dcae5faccab64776376d354decda0017c648bb53 introduced the
shared temp-install.

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/014c5cd8767161995278bc1f4e2fcfb1b703dad1

Modified Files
--------------
src/interfaces/ecpg/test/Makefile | 2 +-
src/test/locale/Makefile          | 1 +
src/test/modules/brin/Makefile    | 2 +-
src/test/regress/GNUmakefile      | 4 ++--
4 files changed, 5 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


view thread (16+ messages)  latest in thread

Message-ID: <E1eBXha-00057r-0d@gemulon.postgresql.org>
Permalink:  ../E1eBXha-00057r-0d@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1eBXha-00057r-0d@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com
  Subject: Re: pgsql: Add a temp-install prerequisite to "check"-like targets not havi
  In-Reply-To: <E1eBXha-00057r-0d@gemulon.postgresql.org>
  References: <E1eBXha-00057r-0d@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox