pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Robert Haas <rhaas@postgresql.org>
To: pgsql-committers@postgresql.org
Subject: pgsql: Fix assertion failure when Parallel Append is run serially.
Date: Wed, 28 Feb 2018 15:59:16 +0000
Message-ID: <E1er48S-0004Lp-HL@gemulon.postgresql.org> (raw)

Fix assertion failure when Parallel Append is run serially.

Parallel-aware plan nodes must be prepared to run without parallelism
if it's not possible at execution time for whatever reason.  Commit
ab72716778128fb63d54ac256adf7fe6820a1185, which introduced Parallel
Append, overlooked this.

Rajkumar Raghuwanshi reported this problem, and I included his test
case in this patch.  The code changes are by me.

Discussion: http://postgr.es/m/CAKcux6=WqkUudLg1GLZZ7fc5ScWC1+Y9qD=pAHeqy32WoeJQvw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ce1663cdcdbd9bf15c81570277f70571b3727dd3

Modified Files
--------------
src/backend/executor/nodeAppend.c             | 21 ++++++++++++++-------
src/test/regress/expected/select_parallel.out | 11 +++++++++++
src/test/regress/sql/select_parallel.sql      |  6 ++++++
3 files changed, 31 insertions(+), 7 deletions(-)



Message-ID: <E1er48S-0004Lp-HL@gemulon.postgresql.org>
Permalink:  ../E1er48S-0004Lp-HL@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1er48S-0004Lp-HL@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: rhaas@postgresql.org
  Subject: Re: pgsql: Fix assertion failure when Parallel Append is run serially.
  In-Reply-To: <E1er48S-0004Lp-HL@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox