pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Magnus Hagander <magnus@hagander.net>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Validate page level checksums in base backups
Date: Tue, 03 Apr 2018 11:52:26 +0000
Message-ID: <E1f3KUE-0003rM-6g@gemulon.postgresql.org> (raw)

Validate page level checksums in base backups

When base backups are run over the replication protocol (for example
using pg_basebackup), verify the checksums of all data blocks if
checksums are enabled. If checksum failures are encountered, log them
as warnings but don't abort the backup.

This becomes the default behaviour in pg_basebackup (provided checksums
are enabled on the server), so add a switch (-k) to disable the checks
if necessary.

Author: Michael Banck
Reviewed-By: Magnus Hagander, David Steele
Discussion: https://postgr.es/m/20180228180856.GE13784@nighthawk.caipicrew.dd-dns.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4eb77d50c21ddd35b77421c27e0d7853eb4f9202

Modified Files
--------------
doc/src/sgml/protocol.sgml                   |  13 +-
doc/src/sgml/ref/pg_basebackup.sgml          |  16 ++
src/backend/replication/basebackup.c         | 227 ++++++++++++++++++++++++++-
src/backend/replication/repl_gram.y          |   8 +-
src/backend/replication/repl_scanner.l       |   1 +
src/bin/pg_basebackup/pg_basebackup.c        |  38 ++++-
src/bin/pg_basebackup/t/010_pg_basebackup.pl |  62 +++++++-
7 files changed, 352 insertions(+), 13 deletions(-)



view thread (23+ messages)  latest in thread

Message-ID: <E1f3KUE-0003rM-6g@gemulon.postgresql.org>
Permalink:  ../E1f3KUE-0003rM-6g@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1f3KUE-0003rM-6g@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: magnus@hagander.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Validate page level checksums in base backups
  In-Reply-To: <E1f3KUE-0003rM-6g@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox