pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
pgsql: Refactor installation of extension headers. 2+ messages / 1 participants [nested] [flat]
* pgsql: Refactor installation of extension headers. @ 2018-09-07 13:40 Andrew Gierth <rhodiumtoad@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Andrew Gierth @ 2018-09-07 13:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Refactor installation of extension headers. Commit be54b3777 failed on gmake 3.80 due to a chained conditional, which on closer examination could be removed entirely with some refactoring elsewhere for a net simplification and more robustness against empty expansions. Along the way, add some more comments. Also make explicit in the documentation and comments that built headers are not removed by 'make clean', since we don't typically want that for headers generated by a separate ./configure step, and it's much easier to add your own 'distclean' rule or use EXTRA_CLEAN than to try and override a deletion rule in pgxs.mk. Per buildfarm member prariedog and comments by Michael Paquier, though all the actual changes are my fault. Branch ------ REL_11_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/094ffd68460a8ba905df7b4eae4e9c690dc6e06f Modified Files -------------- doc/src/sgml/extend.sgml | 14 ++++++++-- src/makefiles/pgxs.mk | 73 ++++++++++++++++++++++++++++-------------------- 2 files changed, 55 insertions(+), 32 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Refactor installation of extension headers. @ 2018-09-07 13:40 Andrew Gierth <rhodiumtoad@postgresql.org> 0 siblings, 0 replies; 2+ messages in thread From: Andrew Gierth @ 2018-09-07 13:40 UTC (permalink / raw) To: pgsql-committers@lists.postgresql.org Refactor installation of extension headers. Commit be54b3777 failed on gmake 3.80 due to a chained conditional, which on closer examination could be removed entirely with some refactoring elsewhere for a net simplification and more robustness against empty expansions. Along the way, add some more comments. Also make explicit in the documentation and comments that built headers are not removed by 'make clean', since we don't typically want that for headers generated by a separate ./configure step, and it's much easier to add your own 'distclean' rule or use EXTRA_CLEAN than to try and override a deletion rule in pgxs.mk. Per buildfarm member prariedog and comments by Michael Paquier, though all the actual changes are my fault. Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/7b6b167fa3bd2f968ad885ca7b024be4122a85f1 Modified Files -------------- doc/src/sgml/extend.sgml | 14 ++++++++-- src/makefiles/pgxs.mk | 73 ++++++++++++++++++++++++++++-------------------- 2 files changed, 55 insertions(+), 32 deletions(-) ^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2018-09-07 13:40 UTC | newest] Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2018-09-07 13:40 pgsql: Refactor installation of extension headers. Andrew Gierth <rhodiumtoad@postgresql.org> 2018-09-07 13:40 pgsql: Refactor installation of extension headers. Andrew Gierth <rhodiumtoad@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox