From: Andrew Gierth <rhodiumtoad@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Refactor installation of extension headers.
Date: Fri, 07 Sep 2018 13:40:07 +0000
Message-ID: <E1fyGzX-0003N4-7L@gemulon.postgresql.org> (raw)
Refactor installation of extension headers.
Commit be54b3777 failed on gmake 3.80 due to a chained conditional,
which on closer examination could be removed entirely with some
refactoring elsewhere for a net simplification and more robustness
against empty expansions. Along the way, add some more comments.
Also make explicit in the documentation and comments that built
headers are not removed by 'make clean', since we don't typically want
that for headers generated by a separate ./configure step, and it's
much easier to add your own 'distclean' rule or use EXTRA_CLEAN than
to try and override a deletion rule in pgxs.mk.
Per buildfarm member prariedog and comments by Michael Paquier, though
all the actual changes are my fault.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7b6b167fa3bd2f968ad885ca7b024be4122a85f1
Modified Files
--------------
doc/src/sgml/extend.sgml | 14 ++++++++--
src/makefiles/pgxs.mk | 73 ++++++++++++++++++++++++++++--------------------
2 files changed, 55 insertions(+), 32 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: rhodiumtoad@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor installation of extension headers.
In-Reply-To: <E1fyGzX-0003N4-7L@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox