pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Ensure that snprintf.c's fmtint() doesn't overflow when printing
Date: Wed, 03 Oct 2018 20:16:36 +0000
Message-ID: <E1g7nZU-0000kU-MB@gemulon.postgresql.org> (raw)

Ensure that snprintf.c's fmtint() doesn't overflow when printing INT64_MIN.

This isn't actually a live bug, as the output happens to be the
same.  But it upsets tools like UBSan, which makes it worthwhile to
fix.

As it's an issue without practical consequences, don't backpatch.

Author: Andres Freund
Discussion: https://postgr.es/m/20180928001121.hhx5n6dsygqxr5wu@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4868e4468590bc32f9c3afed4ec795d6a7732c9d

Modified Files
--------------
src/port/snprintf.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1g7nZU-0000kU-MB@gemulon.postgresql.org>
Permalink:  ../E1g7nZU-0000kU-MB@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1g7nZU-0000kU-MB@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Ensure that snprintf.c's fmtint() doesn't overflow when printing
  In-Reply-To: <E1g7nZU-0000kU-MB@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox