pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Don't forget about failed fsync() requests.
Date: Mon, 19 Nov 2018 04:45:24 +0000
Message-ID: <E1gObR6-00023f-5x@gemulon.postgresql.org> (raw)

Don't forget about failed fsync() requests.

If fsync() fails, md.c must keep the request in its bitmap, so that
future attempts will try again.

Back-patch to all supported releases.

Author: Thomas Munro
Reviewed-by: Amit Kapila
Reported-by: Andrew Gierth
Discussion: https://postgr.es/m/87y3i1ia4w.fsf%40news-spur.riddles.org.uk

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/28117764db7ed0c9fc589dd9323c439235040b05

Modified Files
--------------
src/backend/storage/smgr/md.c | 23 ++++++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)



view thread (6+ messages)  latest in thread

Message-ID: <E1gObR6-00023f-5x@gemulon.postgresql.org>
Permalink:  ../E1gObR6-00023f-5x@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1gObR6-00023f-5x@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Don't forget about failed fsync() requests.
  In-Reply-To: <E1gObR6-00023f-5x@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox