pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Move inheritance expansion code into its own file
Date: Thu, 10 Jan 2019 17:56:32 +0000
Message-ID: <E1gheZE-0002rn-LA@gemulon.postgresql.org> (raw)

Move inheritance expansion code into its own file

This commit moves expand_inherited_tables and underlings from
optimizer/prep/prepunionc.c to optimizer/utils/inherit.c.
Also, all of the AppendRelInfo-based expression manipulation routines
are moved to optimizer/utils/appendinfo.c.

No functional code changes.  One exception is the introduction of
make_append_rel_info, but that's still just moving around code.

Also, stop including <limits.h> in prepunion.c, which no longer needs
it since 3fc6e2d7f5b6.  I (Álvaro) noticed this because Amit was copying
that to inherit.c, which likewise doesn't need it.

Author: Amit Langote
Discussion: https://postgr.es/m/3be67028-a00a-502c-199a-da00eec8fb6e@lab.ntt.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b60c39759908bb2a2dbcfc108ec19bdbdcc278e8

Modified Files
--------------
src/backend/optimizer/path/allpaths.c   |    3 +-
src/backend/optimizer/path/equivclass.c |    2 +-
src/backend/optimizer/path/joinrels.c   |    2 +-
src/backend/optimizer/plan/planmain.c   |    2 +
src/backend/optimizer/plan/planner.c    |    2 +
src/backend/optimizer/prep/prepunion.c  | 1204 -------------------------------
src/backend/optimizer/util/Makefile     |    5 +-
src/backend/optimizer/util/appendinfo.c |  826 +++++++++++++++++++++
src/backend/optimizer/util/inherit.c    |  439 +++++++++++
src/backend/optimizer/util/pathnode.c   |    1 +
src/backend/optimizer/util/relnode.c    |    1 +
src/backend/partitioning/partprune.c    |    1 +
src/include/optimizer/appendinfo.h      |   42 ++
src/include/optimizer/inherit.h         |   22 +
src/include/optimizer/prep.h            |   18 -
15 files changed, 1343 insertions(+), 1227 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1gheZE-0002rn-LA@gemulon.postgresql.org>
Permalink:  ../E1gheZE-0002rn-LA@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1gheZE-0002rn-LA@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Move inheritance expansion code into its own file
  In-Reply-To: <E1gheZE-0002rn-LA@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox