pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Move inheritance expansion code into its own file
3+ messages / 3 participants
[nested] [flat]
* pgsql: Move inheritance expansion code into its own file
@ 2019-01-10 17:56 Alvaro Herrera <alvherre@alvh.no-ip.org>
2019-01-10 18:12 ` Re: pgsql: Move inheritance expansion code into its own file Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 3+ messages in thread
From: Alvaro Herrera @ 2019-01-10 17:56 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Move inheritance expansion code into its own file
This commit moves expand_inherited_tables and underlings from
optimizer/prep/prepunionc.c to optimizer/utils/inherit.c.
Also, all of the AppendRelInfo-based expression manipulation routines
are moved to optimizer/utils/appendinfo.c.
No functional code changes. One exception is the introduction of
make_append_rel_info, but that's still just moving around code.
Also, stop including <limits.h> in prepunion.c, which no longer needs
it since 3fc6e2d7f5b6. I (Álvaro) noticed this because Amit was copying
that to inherit.c, which likewise doesn't need it.
Author: Amit Langote
Discussion: https://postgr.es/m/3be67028-a00a-502c-199a-da00eec8fb6e@lab.ntt.co.jp
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b60c39759908bb2a2dbcfc108ec19bdbdcc278e8
Modified Files
--------------
src/backend/optimizer/path/allpaths.c | 3 +-
src/backend/optimizer/path/equivclass.c | 2 +-
src/backend/optimizer/path/joinrels.c | 2 +-
src/backend/optimizer/plan/planmain.c | 2 +
src/backend/optimizer/plan/planner.c | 2 +
src/backend/optimizer/prep/prepunion.c | 1204 -------------------------------
src/backend/optimizer/util/Makefile | 5 +-
src/backend/optimizer/util/appendinfo.c | 826 +++++++++++++++++++++
src/backend/optimizer/util/inherit.c | 439 +++++++++++
src/backend/optimizer/util/pathnode.c | 1 +
src/backend/optimizer/util/relnode.c | 1 +
src/backend/partitioning/partprune.c | 1 +
src/include/optimizer/appendinfo.h | 42 ++
src/include/optimizer/inherit.h | 22 +
src/include/optimizer/prep.h | 18 -
15 files changed, 1343 insertions(+), 1227 deletions(-)
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Move inheritance expansion code into its own file
2019-01-10 17:56 pgsql: Move inheritance expansion code into its own file Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2019-01-10 18:12 ` Tom Lane <tgl@sss.pgh.pa.us>
2019-01-10 18:57 ` Re: pgsql: Move inheritance expansion code into its own file Alvaro Herrera <alvherre@2ndquadrant.com>
0 siblings, 1 reply; 3+ messages in thread
From: Tom Lane @ 2019-01-10 18:12 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: pgsql-committers@lists.postgresql.org
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Move inheritance expansion code into its own file
Hm, why does appendinfo.h need to depend on plannodes.h?
I don't see anything in it that looks like it comes from there.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pgsql: Move inheritance expansion code into its own file
2019-01-10 17:56 pgsql: Move inheritance expansion code into its own file Alvaro Herrera <alvherre@alvh.no-ip.org>
2019-01-10 18:12 ` Re: pgsql: Move inheritance expansion code into its own file Tom Lane <tgl@sss.pgh.pa.us>
@ 2019-01-10 18:57 ` Alvaro Herrera <alvherre@2ndquadrant.com>
0 siblings, 0 replies; 3+ messages in thread
From: Alvaro Herrera @ 2019-01-10 18:57 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org
On 2019-Jan-10, Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Move inheritance expansion code into its own file
>
> Hm, why does appendinfo.h need to depend on plannodes.h?
> I don't see anything in it that looks like it comes from there.
Yeah, probably no good reason.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2019-01-10 18:57 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 17:56 pgsql: Move inheritance expansion code into its own file Alvaro Herrera <alvherre@alvh.no-ip.org>
2019-01-10 18:12 ` Tom Lane <tgl@sss.pgh.pa.us>
2019-01-10 18:57 ` Alvaro Herrera <alvherre@2ndquadrant.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox