pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Remove useless casts
3+ messages / 1 participants
[nested] [flat]

* pgsql: Remove useless casts
@ 2019-02-13 11:18  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Peter Eisentraut @ 2019-02-13 11:18 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove useless casts

Some of these were uselessly casting away "const", some were just
nearby, but they where all unnecessary anyway.

Discussion: https://www.postgresql.org/message-id/flat/53a28052-f9f3-1808-fed9-460fd43035ab%402ndquadrant.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cf40dc65b676c8df1ee12f060b40f0e37a183e04

Modified Files
--------------
contrib/btree_gist/btree_utils_num.c | 24 ++++++++++++------------
src/backend/catalog/heap.c           |  2 +-
src/common/unicode_norm.c            |  2 +-
3 files changed, 14 insertions(+), 14 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Remove useless casts
@ 2021-09-09 06:58  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Peter Eisentraut @ 2021-09-09 06:58 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove useless casts

Casting the argument of strVal() to (Value *) is useless, since
strVal() already does that.

Most code didn't do that anyway; this was apparently just a style that
snuck into certain files.

Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/5ba6bc5b-3f95-04f2-2419-f8ddb4c046fb@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cbdf75bf8053f88bbae6b307f34ab057424a370f

Modified Files
--------------
src/backend/catalog/objectaddress.c | 20 ++++++++++----------
src/backend/commands/alter.c        | 16 ++++++++--------
src/backend/commands/comment.c      |  2 +-
src/backend/commands/dropcmds.c     | 16 ++++++++--------
src/backend/commands/statscmds.c    |  2 +-
5 files changed, 28 insertions(+), 28 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* pgsql: Remove useless casts
@ 2022-11-16 15:02  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 3+ messages in thread

From: Peter Eisentraut @ 2022-11-16 15:02 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Remove useless casts

Maybe these are left from when PageGetItem() was a macro, but now they
are clearly useless.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d1cb4e9f92c3db5c8fb52ccd1d502c73ffcc47e0

Modified Files
--------------
src/backend/access/heap/heapam.c         | 10 +++++-----
src/backend/access/heap/heapam_handler.c |  4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2022-11-16 15:02 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-02-13 11:18 pgsql: Remove useless casts Peter Eisentraut <peter@eisentraut.org>
2021-09-09 06:58 pgsql: Remove useless casts Peter Eisentraut <peter@eisentraut.org>
2022-11-16 15:02 pgsql: Remove useless casts Peter Eisentraut <peter@eisentraut.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox