pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Remove useless casts
Date: Thu, 09 Sep 2021 06:58:19 +0000
Message-ID: <E1mOE0p-0005s4-Ay@gemulon.postgresql.org> (raw)

Remove useless casts

Casting the argument of strVal() to (Value *) is useless, since
strVal() already does that.

Most code didn't do that anyway; this was apparently just a style that
snuck into certain files.

Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/5ba6bc5b-3f95-04f2-2419-f8ddb4c046fb@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cbdf75bf8053f88bbae6b307f34ab057424a370f

Modified Files
--------------
src/backend/catalog/objectaddress.c | 20 ++++++++++----------
src/backend/commands/alter.c        | 16 ++++++++--------
src/backend/commands/comment.c      |  2 +-
src/backend/commands/dropcmds.c     | 16 ++++++++--------
src/backend/commands/statscmds.c    |  2 +-
5 files changed, 28 insertions(+), 28 deletions(-)



view thread (3+ messages)  latest in thread

Message-ID: <E1mOE0p-0005s4-Ay@gemulon.postgresql.org>
Permalink:  ../E1mOE0p-0005s4-Ay@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1mOE0p-0005s4-Ay@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org
  Subject: Re: pgsql: Remove useless casts
  In-Reply-To: <E1mOE0p-0005s4-Ay@gemulon.postgresql.org>
  References: <E1mOE0p-0005s4-Ay@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox