pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter@eisentraut.org>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Fix volatile vs. pointer confusion
Date: Fri, 15 Mar 2019 07:59:51 +0000
Message-ID: <E1h4hkt-0006Nu-HX@gemulon.postgresql.org> (raw)

Fix volatile vs. pointer confusion

Variables used after a longjmp() need to be declared volatile.  In
case of a pointer, it's the pointer itself that needs to be declared
volatile, not the pointed-to value.  So we need

    PyObject *volatile items;

instead of

    volatile PyObject *items;  /* wrong */

Discussion: https://www.postgresql.org/message-id/flat/f747368d-9e1a-c46a-ac76-3c27da32e8e4%402ndquadrant.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a1e9508b964155a81ec9a8e6e12be76796d47097

Modified Files
--------------
contrib/hstore_plpython/hstore_plpython.c | 9 ++++-----
contrib/jsonb_plpython/jsonb_plpython.c   | 9 +++------
2 files changed, 7 insertions(+), 11 deletions(-)



view thread (5+ messages)

Message-ID: <E1h4hkt-0006Nu-HX@gemulon.postgresql.org>
Permalink:  ../E1h4hkt-0006Nu-HX@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1h4hkt-0006Nu-HX@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: peter@eisentraut.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix volatile vs. pointer confusion
  In-Reply-To: <E1h4hkt-0006Nu-HX@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox