pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Fix volatile vs. pointer confusion
5+ messages / 1 participants
[nested] [flat]

* pgsql: Fix volatile vs. pointer confusion
@ 2019-03-14 07:46  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Peter Eisentraut @ 2019-03-14 07:46 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix volatile vs. pointer confusion

Variables used after a longjmp() need to be declared volatile.  In
case of a pointer, it's the pointer itself that needs to be declared
volatile, not the pointed-to value.  So we need

    PyObject *volatile items;

instead of

    volatile PyObject *items;  /* wrong */

Discussion: https://www.postgresql.org/message-id/flat/f747368d-9e1a-c46a-ac76-3c27da32e8e4%402ndquadrant.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1226d932b4dadc39ba2f9a488e4d784443ea6a78

Modified Files
--------------
contrib/hstore_plpython/hstore_plpython.c | 9 ++++-----
contrib/jsonb_plpython/jsonb_plpython.c   | 9 +++------
2 files changed, 7 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Fix volatile vs. pointer confusion
@ 2019-03-15 07:59  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Peter Eisentraut @ 2019-03-15 07:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix volatile vs. pointer confusion

Variables used after a longjmp() need to be declared volatile.  In
case of a pointer, it's the pointer itself that needs to be declared
volatile, not the pointed-to value.  So we need

    PyObject *volatile items;

instead of

    volatile PyObject *items;  /* wrong */

Discussion: https://www.postgresql.org/message-id/flat/f747368d-9e1a-c46a-ac76-3c27da32e8e4%402ndquadrant.com

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/361cabb11d36afaf466d76e1bda1778501137dcf

Modified Files
--------------
contrib/hstore_plpython/hstore_plpython.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Fix volatile vs. pointer confusion
@ 2019-03-15 07:59  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Peter Eisentraut @ 2019-03-15 07:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix volatile vs. pointer confusion

Variables used after a longjmp() need to be declared volatile.  In
case of a pointer, it's the pointer itself that needs to be declared
volatile, not the pointed-to value.  So we need

    PyObject *volatile items;

instead of

    volatile PyObject *items;  /* wrong */

Discussion: https://www.postgresql.org/message-id/flat/f747368d-9e1a-c46a-ac76-3c27da32e8e4%402ndquadrant.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c77f21899ac2bd85d9d30d2dbf60904498ebee2f

Modified Files
--------------
contrib/hstore_plpython/hstore_plpython.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Fix volatile vs. pointer confusion
@ 2019-03-15 07:59  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Peter Eisentraut @ 2019-03-15 07:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix volatile vs. pointer confusion

Variables used after a longjmp() need to be declared volatile.  In
case of a pointer, it's the pointer itself that needs to be declared
volatile, not the pointed-to value.  So we need

    PyObject *volatile items;

instead of

    volatile PyObject *items;  /* wrong */

Discussion: https://www.postgresql.org/message-id/flat/f747368d-9e1a-c46a-ac76-3c27da32e8e4%402ndquadrant.com

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/626c8ed2ef6dbca7df7d445875d133638b360dd1

Modified Files
--------------
contrib/hstore_plpython/hstore_plpython.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Fix volatile vs. pointer confusion
@ 2019-03-15 07:59  Peter Eisentraut <peter@eisentraut.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Peter Eisentraut @ 2019-03-15 07:59 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix volatile vs. pointer confusion

Variables used after a longjmp() need to be declared volatile.  In
case of a pointer, it's the pointer itself that needs to be declared
volatile, not the pointed-to value.  So we need

    PyObject *volatile items;

instead of

    volatile PyObject *items;  /* wrong */

Discussion: https://www.postgresql.org/message-id/flat/f747368d-9e1a-c46a-ac76-3c27da32e8e4%402ndquadrant.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a1e9508b964155a81ec9a8e6e12be76796d47097

Modified Files
--------------
contrib/hstore_plpython/hstore_plpython.c | 9 ++++-----
contrib/jsonb_plpython/jsonb_plpython.c   | 9 +++------
2 files changed, 7 insertions(+), 11 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2019-03-15 07:59 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-03-14 07:46 pgsql: Fix volatile vs. pointer confusion Peter Eisentraut <peter@eisentraut.org>
2019-03-15 07:59 pgsql: Fix volatile vs. pointer confusion Peter Eisentraut <peter@eisentraut.org>
2019-03-15 07:59 pgsql: Fix volatile vs. pointer confusion Peter Eisentraut <peter@eisentraut.org>
2019-03-15 07:59 pgsql: Fix volatile vs. pointer confusion Peter Eisentraut <peter@eisentraut.org>
2019-03-15 07:59 pgsql: Fix volatile vs. pointer confusion Peter Eisentraut <peter@eisentraut.org>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox