From: Noah Misch <noah@leadboat.com>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Consistently test for in-use shared memory.
Date: Sat, 13 Apr 2019 05:53:57 +0000
Message-ID: <E1hFBbx-0002OR-Qy@gemulon.postgresql.org> (raw)
Consistently test for in-use shared memory.
postmaster startup scrutinizes any shared memory segment recorded in
postmaster.pid, exiting if that segment matches the current data
directory and has an attached process. When the postmaster.pid file was
missing, a starting postmaster used weaker checks. Change to use the
same checks in both scenarios. This increases the chance of a startup
failure, in lieu of data corruption, if the DBA does "kill -9 `head -n1
postmaster.pid` && rm postmaster.pid && pg_ctl -w start". A postmaster
will no longer stop if shmat() of an old segment fails with EACCES. A
postmaster will no longer recycle segments pertaining to other data
directories. That's good for production, but it's bad for integration
tests that crash a postmaster and immediately delete its data directory.
Such a test now leaks a segment indefinitely. No "make check-world"
test does that. win32_shmem.c already avoided all these problems. In
9.6 and later, enhance PostgresNode to facilitate testing. Back-patch
to 9.4 (all supported versions).
Reviewed (in earlier versions) by Daniel Gustafsson and Kyotaro HORIGUCHI.
Discussion: https://postgr.es/m/20190408064141.GA2016666@rfd.leadboat.com
Branch
------
REL9_4_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/3ef5e16c618177160bc5f95216dccab3588defdc
Modified Files
--------------
src/backend/port/sysv_shmem.c | 269 +++++++++++++++++++++---------------
src/backend/port/win32_shmem.c | 7 +-
src/backend/postmaster/postmaster.c | 12 +-
src/backend/storage/ipc/ipci.c | 14 +-
src/backend/utils/init/postinit.c | 6 +-
src/include/storage/ipc.h | 2 +-
src/include/storage/pg_shmem.h | 6 +-
7 files changed, 175 insertions(+), 141 deletions(-)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: noah@leadboat.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Consistently test for in-use shared memory.
In-Reply-To: <E1hFBbx-0002OR-Qy@gemulon.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox