pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-committers@lists.postgresql.org
Subject: pgsql: Make pg_upgrade's test.sh less chatty.
Date: Tue, 21 May 2019 17:12:04 +0000
Message-ID: <E1hT8J2-0007nF-O4@gemulon.postgresql.org> (raw)

Make pg_upgrade's test.sh less chatty.

The use of "set -x" to echo a subset of the test's commands might've
been a good idea during development of this test, but it's been stable
for long enough now that the extra output isn't very useful.  Also
our project expectations have been trending towards less output in
non-error cases; the fact that "set -x" produces output on stderr
is particularly annoying from that standpoint.  So get rid of it.

Also, pass "-A trust" to initdb explicitly so that it won't issue
a warning about "trust" being an insecure default.  This matches
what the TAP tests have done for a long time, and again gets rid
of some noise on stderr.

Discussion: https://postgr.es/m/21766.1558397960@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eb9812f272db8e93416831e5254569b76edf8264

Modified Files
--------------
src/bin/pg_upgrade/test.sh | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)



view thread (8+ messages)  latest in thread

Message-ID: <E1hT8J2-0007nF-O4@gemulon.postgresql.org>
Permalink:  ../E1hT8J2-0007nF-O4@gemulon.postgresql.org/
Also on:    postgresql.org/message-id/E1hT8J2-0007nF-O4@gemulon.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us
  Subject: Re: pgsql: Make pg_upgrade's test.sh less chatty.
  In-Reply-To: <E1hT8J2-0007nF-O4@gemulon.postgresql.org>
  References: <E1hT8J2-0007nF-O4@gemulon.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox